Closed
Bug 1429009
Opened 6 years ago
Closed 6 years ago
ChannelMediaDecoder::DownloadProgressed() should notify 'DownloadProgressed' immediately
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(2 files)
https://searchfox.org/mozilla-central/rev/cf149b7b63ff97023e28723167725e38cf5df757/dom/media/ChannelMediaDecoder.cpp#441 Since GetOwner()->DownloadProgressed() is called asynchronously by ChannelMediaDecoder::DownloadProgressed(), it is possible for HTMLMediaElement::DownloadSuspended() to happen first and change the network state to IDEL. Then HTMLMediaElement::DownloadProgressed() will do nothing seeing mNetworkState is not LOADING and readyState won't be updated correctly.
|
Assignee | |
Updated•6 years ago
|
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8941302 -
Flags: review?(bechen)
Attachment #8941303 -
Flags: review?(bechen)
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8941302 [details] Bug 1429009. P1 - notify 'DownloadProgressed' immediately to preserve the event order. https://reviewboard.mozilla.org/r/211596/#review217360
Attachment #8941302 -
Flags: review?(bechen) → review+
|
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8941303 [details] Bug 1429009. P2 - remove unnecessary AbstractThread::AutoEnter. https://reviewboard.mozilla.org/r/211598/#review217362
Attachment #8941303 -
Flags: review?(bechen) → review+
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8941302 -
Flags: review?(gsquelart)
Attachment #8941303 -
Flags: review?(gsquelart)
|
||
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8941302 [details] Bug 1429009. P1 - notify 'DownloadProgressed' immediately to preserve the event order. https://reviewboard.mozilla.org/r/211596/#review217364
Attachment #8941302 -
Flags: review?(gsquelart) → review+
|
|
||
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8941303 [details] Bug 1429009. P2 - remove unnecessary AbstractThread::AutoEnter. https://reviewboard.mozilla.org/r/211598/#review217366
Attachment #8941303 -
Flags: review?(gsquelart) → review+
|
|
Assignee | |
Comment 7•6 years ago
|
||
Thanks for the reviews!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a6c837be3b4 P1 - notify 'DownloadProgressed' immediately to preserve the event order. r=bechen,gerald https://hg.mozilla.org/integration/autoland/rev/72b59b20a048 P2 - remove unnecessary AbstractThread::AutoEnter. r=bechen,gerald
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9a6c837be3b4 https://hg.mozilla.org/mozilla-central/rev/72b59b20a048
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•