Add spotlight support to the Form Autofill FTU doorhanger

RESOLVED FIXED in Firefox 60

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: scottwu, Assigned: joseph.fergusson, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
The Spotlight feature makes it possible to open and highlight a section in preferences:
about:preferences#privacy-address-autofill

Form Autofill doorhangers should implement this feature.
(Reporter)

Updated

a year ago
Summary: Add spotlight support to doorhanger → Add spotlight support to Form Autofill doorhangers
1a) Change "panePrivacy" to "privacy-address-autofill" on https://dxr.mozilla.org/mozilla-central/rev/8b1f0ca44c7be9a15bfbedf0cde540831f2e2aec/browser/extensions/formautofill/FormAutofillParent.jsm#446
2b) Update the test at https://dxr.mozilla.org/mozilla-central/rev/9fe69ff0762da191fbd2b9fc0718e96f1ab4137e/browser/extensions/formautofill/test/browser/browser_first_time_use_doorhanger.js#18,90 to check that the correct section is highlighted.

If you open the page about:config in the address bar, you can toggle extensions.formautofill.firstTimeUse to reset the state to allow the first-time-use doorhanger to appear upon first address form submission. Test forms are at https://luke-chang.github.io/autofill-demo/

2) Change "about:preferences#privacy" to "about:preferences#privacy-address-autofill" or "about:preferences#privacy-credit-card-autofill" depending on which doorhanger is showing: https://dxr.mozilla.org/mozilla-central/rev/8b1f0ca44c7be9a15bfbedf0cde540831f2e2aec/browser/extensions/formautofill/FormAutofillDoorhanger.jsm#38-39,74,79,101,106,156,161,241
Assignee: nobody → MattN+bmo
Mentor: MattN+bmo
Status: NEW → ASSIGNED
Priority: -- → P3
(Assignee)

Comment 2

a year ago
Posted patch 1429017.patchSplinter Review
Attachment #8944582 - Flags: review?(MattN+bmo)
Assignee: MattN+bmo → joseph.fergusson
Comment on attachment 8944582 [details] [diff] [review]
1429017.patch

Review of attachment 8944582 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this only covers part 1, not part 2
Comment on attachment 8944582 [details] [diff] [review]
1429017.patch

Review of attachment 8944582 [details] [diff] [review]:
-----------------------------------------------------------------

I'll file a new bug for comment 1 #2.
Attachment #8944582 - Flags: review?(MattN+bmo) → review+

Comment 5

a year ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a7e34625fb8
Added spotlight upon clicking view in preferences in address autofill doorhanger r=MattN
Summary: Add spotlight support to Form Autofill doorhangers → Add spotlight support to the Form Autofill FTU doorhanger

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2a7e34625fb8
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.