1429017 - Add spotlight support to the Form Autofill FTU doorhanger

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, enhancement, P3)

Description

[Scott Wu [:scottwu]]

The Spotlight feature makes it possible to open and highlight a section in preferences:
about:preferences#privacy-address-autofill

Form Autofill doorhangers should implement this feature.

Comment 1

[Matthew N. [:MattN]]

1a) Change "panePrivacy" to "privacy-address-autofill" on https://dxr.mozilla.org/mozilla-central/rev/8b1f0ca44c7be9a15bfbedf0cde540831f2e2aec/browser/extensions/formautofill/FormAutofillParent.jsm#446
2b) Update the test at https://dxr.mozilla.org/mozilla-central/rev/9fe69ff0762da191fbd2b9fc0718e96f1ab4137e/browser/extensions/formautofill/test/browser/browser_first_time_use_doorhanger.js#18,90 to check that the correct section is highlighted.

If you open the page about:config in the address bar, you can toggle extensions.formautofill.firstTimeUse to reset the state to allow the first-time-use doorhanger to appear upon first address form submission. Test forms are at https://luke-chang.github.io/autofill-demo/

2) Change "about:preferences#privacy" to "about:preferences#privacy-address-autofill" or "about:preferences#privacy-credit-card-autofill" depending on which doorhanger is showing: https://dxr.mozilla.org/mozilla-central/rev/8b1f0ca44c7be9a15bfbedf0cde540831f2e2aec/browser/extensions/formautofill/FormAutofillDoorhanger.jsm#38-39,74,79,101,106,156,161,241

Comment 2

[joseph.fergusson]

Attachment: 1429017.patch

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8944582 [details] [diff] [review]
1429017.patch

Review of attachment 8944582 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this only covers part 1, not part 2

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8944582 [details] [diff] [review]
1429017.patch

Review of attachment 8944582 [details] [diff] [review]:
-----------------------------------------------------------------

I'll file a new bug for comment 1 #2.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a7e34625fb8
Added spotlight upon clicking view in preferences in address autofill doorhanger r=MattN

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2a7e34625fb8