1429078 - Crash in SubDocEnumCb

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-0ddfd069-5221-4b26-82e0-67e880180109.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll SubDocEnumCb layout/painting/RetainedDisplayListBuilder.cpp:554
1 xul.dll nsDocument::EnumerateSubDocuments dom/base/nsDocument.cpp:8693
2 xul.dll GetModifiedFrames layout/painting/RetainedDisplayListBuilder.cpp:582
3 xul.dll RetainedDisplayListBuilder::AttemptPartialUpdate layout/painting/RetainedDisplayListBuilder.cpp:835
4 xul.dll nsLayoutUtils::PaintFrame layout/base/nsLayoutUtils.cpp:3817
5 xul.dll mozilla::PresShell::Paint layout/base/PresShell.cpp:6485
6 xul.dll mozilla::dom::TabChild::RecvRenderLayers dom/ipc/TabChild.cpp:2777
7 xul.dll mozilla::dom::TabChild::ForcePaint dom/ipc/TabChild.cpp:3581
8 xul.dll `anonymous namespace'::HangMonitorChild::InterruptCallback dom/ipc/ProcessHangMonitor.cpp:346
9 xul.dll InterruptCallback dom/ipc/ProcessHangMonitor.cpp:1143

=============================================================

There is 5 crashes (from the same installation) in nightly 59 with buildid 20180109100117. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1418840.

[1] https://hg.mozilla.org/mozilla-central/rev/7d6ea086117d

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: subdoc-crash

Comment 2

[Miko Mynttinen]

Comment on attachment 8941301 [details] [diff] [review]
subdoc-crash

Review of attachment 8941301 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0656d11f1328
Handle the case where the subdoc view doesn't have a frame. r=miko

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0656d11f1328

Comment 5

[Calixte Denizet (:calixte)]

There still are 112 crashes in nightly 59/60 starting with buildid 20180117100129 (the first build after the patch landed).

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Matt, can you take a second look since we still have crashes showing up?

Comment 7

[Matt Woodrow (:mattwoodrow)]

I think bug 1430258 will resolve the remainder of the issues here.