1429082 - Remove unused classes from proxy module

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

There are several unused IPC helper classes in testing/marionette/proxy.js
that can now be removed in their entirety.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1429082 - Drop AsyncChromeSender from proxy module.

The AsyncChromeSender and its factory construction function
proxy.toChromeAsync are no longer in use.

Review commit: https://reviewboard.mozilla.org/r/211358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211358/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1429082 - Drop SyncChromeSender from proxy module.

The SyncChromeSender class and its factory construction function
proxy.toChrome is not used in Marionette and can be safely removed.

Review commit: https://reviewboard.mozilla.org/r/211360/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211360/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8941088 [details]
Bug 1429082 - Drop AsyncChromeSender from proxy module.

https://reviewboard.mozilla.org/r/211358/#review217270

::: commit-message-6f5fa:4
(Diff revision 1)
> +Bug 1429082 - Drop AsyncChromeSender from proxy module. r?whimboo
> +
> +The AsyncChromeSender and its factory construction function
> +proxy.toChromeAsync are no longer in use.

When I search under testing/marionette I can still find it in the docs. Can you please make sure to regenerate those? Also you said this is done via a cron job, but that code was removed 3 months ago via bug 1405279. Is that busted?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8941088 [details]
Bug 1429082 - Drop AsyncChromeSender from proxy module.

https://reviewboard.mozilla.org/r/211358/#review217272

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8941089 [details]
Bug 1429082 - Drop SyncChromeSender from proxy module.

https://reviewboard.mozilla.org/r/211360/#review217274

Great to see this cleanup!

Comment 6

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #3)

> When I search under testing/marionette I can still find it in the
> docs. Can you please make sure to regenerate those? Also you said
> this is done via a cron job, but that code was removed 3 months
> ago via bug 1405279. Is that busted?

Thanks for reminindg me.

I never enabled the cron job because I wasn’t entirely confident in
its reliability.  Since then someone wrote to dev-platform@ about
integrating jsdoc with Sphinx and the Firefox source docs.  I will
research that some more tomorrow and also regenerate the docs.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6295a6ab95a
Drop AsyncChromeSender from proxy module. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/2224eacab99e
Drop SyncChromeSender from proxy module. r=whimboo

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e6295a6ab95a
https://hg.mozilla.org/mozilla-central/rev/2224eacab99e