1429091 - Use global message manager in AsyncMessageChannel

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

We pass in a closure that returns GeckoDriver#mm to AsyncMessageChannel
in the testing/marionette/proxy.js module.  This is unnecessary
because, at the time a message is sent, GeckoDriver#mm is always
the global message manager.  We can make this more losely coupled
by picking up the global message manager directly from an import.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1429091 - Use global message manager in AsyncMessageChannel.

Whenever we make proxied IPC calls to the content frame's message manager,
we do so over the global message manager.  AsyncMessageChannel takes a
closure that returns the current message manager from GeckoDriver#mm,
but this is unnecessary because it always holds a global message channel.

By not having to pass in a closure returning a message manager
to AsyncMessageChannel we losen the tight coupling a little bit.
Future patches will further reduce the tight coupling of browserFn.

Review commit: https://reviewboard.mozilla.org/r/211364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211364/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8941095 [details]
Bug 1429091 - Use global message manager in AsyncMessageChannel.

https://reviewboard.mozilla.org/r/211364/#review217806

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s cbcdffa2dccf -d 706bf6511a6f: rebasing 441958:cbcdffa2dccf "Bug 1429091 - Use global message manager in AsyncMessageChannel. r=maja_zf" (tip)
merging testing/marionette/driver.js
merging testing/marionette/listener.js
merging testing/marionette/proxy.js
warning: conflicts while merging testing/marionette/proxy.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8941095 [details]
Bug 1429091 - Use global message manager in AsyncMessageChannel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211364/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82d3a173d23c
Use global message manager in AsyncMessageChannel. r=maja_zf

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/82d3a173d23c