Closed Bug 1429091 Opened 2 years ago Closed 2 years ago

Use global message manager in AsyncMessageChannel

Categories

(Testing :: Marionette, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(1 file)

We pass in a closure that returns GeckoDriver#mm to AsyncMessageChannel
in the testing/marionette/proxy.js module.  This is unnecessary
because, at the time a message is sent, GeckoDriver#mm is always
the global message manager.  We can make this more losely coupled
by picking up the global message manager directly from an import.
Assignee: nobody → ato
Comment on attachment 8941095 [details]
Bug 1429091 - Use global message manager in AsyncMessageChannel.

https://reviewboard.mozilla.org/r/211364/#review217806
Attachment #8941095 - Flags: review?(mjzffr) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s cbcdffa2dccf -d 706bf6511a6f: rebasing 441958:cbcdffa2dccf "Bug 1429091 - Use global message manager in AsyncMessageChannel. r=maja_zf" (tip)
merging testing/marionette/driver.js
merging testing/marionette/listener.js
merging testing/marionette/proxy.js
warning: conflicts while merging testing/marionette/proxy.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82d3a173d23c
Use global message manager in AsyncMessageChannel. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/82d3a173d23c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.