Closed Bug 1429154 Opened 3 years ago Closed 3 years ago

Remove FXA_VERIFICATION_METHOD probe

Categories

(Firefox :: Sync, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: eoger, Assigned: eoger)

References

Details

Attachments

(1 file)

It looks like this probe will expire on 2018-01-22.
From what I understood, we have gathered enough data to reach a conclusion and we should stop collecting more. Thoughts?
IIRC this was about seeing whether push notifications were helpful to verification, and the conclusion was that they are indeed, so :thumbsup: to removing it
SGTM
Depends on: 1353645
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8942677 [details]
Bug 1429154 - Remove FXA_VERIFICATION_METHOD probe.

https://reviewboard.mozilla.org/r/212934/#review218860

LGTM.

::: services/fxaccounts/FxAccounts.jsm:1289
(Diff revision 1)
>      this.currentTimer = setTimeout(() => {
>        this.pollEmailStatus(currentState, sessionToken, why);
>      }, nextPollMs);
>    },
>  
>    async onPollEmailSuccess(currentState, why) {

How hard would it be to remove and un-thread the `why` parameter from the rest of the code? If it doesn't seem like too much work can we remove it?
Attachment #8942677 - Flags: review?(tchiovoloni) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83d55f6e89b9
Remove FXA_VERIFICATION_METHOD probe. r=tcsc
https://hg.mozilla.org/mozilla-central/rev/83d55f6e89b9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.