1429179 - Policy: Clear all data when the browser exits

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[:Felipe Gomes (needinfo for replies!)]

There's the Always on Private browsing (Preferences -> Never remember History) and this is probably what this request is about. 

(There's also the pref privacy.sanitize.sanitizeOnShutdown, but it shows UI to the user upon exit, which is probably not desired)

Comment 1

[Mike Kaply [:mkaply]]

We can do it ourselves using Sanitizer.sanitize

https://searchfox.org/mozilla-central/source/browser/modules/Sanitizer.jsm#931

The ones that default to true are:

cache
cookies
downloads
formdata
history
openWindows
sessions

The ones that default to false are:

offlineApps
siteSettings

Not sure how to write a test for this though...

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Isn't it easier to just use the browser.privatebrowsing.autostart pref?

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1429179 - Add policy to clear data on shutdown.

Review commit: https://reviewboard.mozilla.org/r/233398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233398/

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8964696 [details]
Bug 1429179 - Add policy to clear data on shutdown.

https://reviewboard.mozilla.org/r/233398/#review239376

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 3c1781d850bd56cd87f8713efce4daa0995ee0e5 -d 61c57ad4f4f4: rebasing 456140:3c1781d850bd "Bug 1429179 - Add policy to clear data on shutdown. r=Felipe" (tip)
merging browser/components/enterprisepolicies/Policies.jsm
merging browser/components/enterprisepolicies/schemas/policies-schema.json
merging browser/components/enterprisepolicies/tests/browser/browser_policies_simple_pref_policies.js
warning: conflicts while merging browser/components/enterprisepolicies/tests/browser/browser_policies_simple_pref_policies.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f5c38e04808
Add policy to clear data on shutdown. r=felipe

Comment 7

[:Felipe Gomes (needinfo for replies!)]

[Tracking Requested - why for this release]:
Enterprise Policies

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8964696 [details]
Bug 1429179 - Add policy to clear data on shutdown.

Approval Request Comment
[Feature/Bug causing the regression]: Enterprise Policies
[User impact if declined]: Policy to clear data on shutdown
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: QA will handle it
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: policy just sets the right prefs for it
[String changes made/needed]: no

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7f5c38e04808

Comment 10

[Abe - QA (:Abe_LV)]

We tested this on the latest nightly with JSON policy format and it is verified as fixed.
This policy checks and locks "Clear history when Nightly Close" and all of the options under the [Setting] button. 

We will retest this with adm policy format when ready.

Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8964696 [details]
Bug 1429179 - Add policy to clear data on shutdown.

enterprise policy, approved for 60.0b11

Comment 12

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-beta/rev/eaed35c9992d0e8727599967c47e4b6a60bb59b0

Comment 13

[Abe - QA (:Abe_LV)]

We retested this on beta builds[FX60] with ADM and JSON policy formats and it is verified as fixed.

Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760