Closed Bug 1429211 Opened 4 years ago Closed 4 years ago

Implement the "success" screen for when the merchant accepts the payment

Categories

(Firefox :: WebPayments UI, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: MattN, Assigned: jaws)

References

()

Details

(Whiteboard: [webpayments])

Attachments

(1 file)

After sending the PaymentResponse to the merchant via the DOM code, the merchant responds to indicate if the payment was accepted or rejected. If the front-end code receives `nsIPaymentActionResponse.PAYMENT_ACCEPTED` then success UI should appear.

The UI shouldn't over-promise that any transaction is actually complete, just that the payment details were given to the merchant.
Summary: Implement the "success" screen for when the merchant accepts the payment and doesn't request retrying → Implement the "success" screen for when the merchant accepts the payment
Priority: P3 → P1
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8954629 [details]
Bug 1429211 - Implement the 'success' screen for when the merchant accepts the payment.

https://reviewboard.mozilla.org/r/223706/#review229764

::: toolkit/components/payments/test/mochitest/test_payment_dialog.html:123
(Diff revision 2)
>    ok(!payButton.disabled, "Button is still enabled");
> +  await el1.requestStore.setState({completionState: "success"});

Nit: for the future this should have been it's own test task for clarity since there would be minimal overhead to doing so and it would have improved the log output are readability.
Attachment #8954629 - Flags: review?(MattN+bmo) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/884c918d978c
Implement the 'success' screen for when the merchant accepts the payment. r=MattN
https://hg.mozilla.org/mozilla-central/rev/884c918d978c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Whiteboard: [webpayments]
Product: Toolkit → Firefox
Target Milestone: mozilla60 → Firefox 60
You need to log in before you can comment on or make changes to this bug.