1429215 - Make assertion condition more sensitive / less crashy in GetFloatFromPlaceholder

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

As noted in bug 1429172 comment 1: That bug's testcase currently crashes debug builds **while we're evaluating the assertion condition**.  We crash because the assertion dereferences a pointer that we haven't bothered to null-check (because we have good reason to believe it should be non-null, though in this case it does happen to be null, hence we crash).

We should just broaden the assertion to *also* assert that the pointer is non-null, so that we fail the assertion rather than crashing inside of its condition.

Comment 1

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Attachment: Bug 1429215: Null-check pointer before using it in assertion in GetFloatFromPlaceholder() (to avoid crashing during assertion).

Review commit: https://reviewboard.mozilla.org/r/211472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211472/

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 8941203 [details]
Bug 1429215: Null-check pointer before using it in assertion in GetFloatFromPlaceholder() (to avoid crashing during assertion).

https://reviewboard.mozilla.org/r/211472/#review217308

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bef5e30e6243
Null-check pointer before using it in assertion in GetFloatFromPlaceholder() (to avoid crashing during assertion). r=mats

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bef5e30e6243