1429223 - Remove eslintvalidate.py vcs hooks

Status: RESOLVED FIXED

(Firefox Build System :: Lint and Formatting, enhancement)

Description

[Andrew Halberstadt [:ahal]]

I was helping someone out who's lint hooks were failing. Turns out he was using the old eslintvalidate extension, and upgrading to the new hooks.py method fixed the issue for him (I didn't dig into the issue further).

We want to encourage people to use hooks.py anyway, as that does more than just eslint. I propose we remove it in two phases:

1) Modify the eslintvalidate.py hooks to print an error message with a link to the documentation on setting up the new hook.
2) After some period of time (a couple weeks?), remove them entirely.

This should prevent people from getting confused by "eslintvalidate not found" errors. This should also get posted to the newsgroups before we do anything.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1429223 - [lint] Obsolete the eslintvalidate hooks by printing error message with upgrade path,

This replaces the eslintvalidate hooks with an error message
prompting the user to upgrade to tools/lint/hooks.py.

The reasons for deprecating eslintvalidate are twofold:

1) It only runs eslint, so developers might miss errors from
other linters.

2) It isn't as well maintained, and I've started to see
reports of problems in the wild. It doesn't make sense to
maintain two sets of hooks that do the same thing.

Review commit: https://reviewboard.mozilla.org/r/211564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211564/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8941288 [details]
Bug 1429223 - [lint] Obsolete the eslintvalidate hooks by printing error message with upgrade path,

https://reviewboard.mozilla.org/r/211564/#review217428

Looks good, we should totally do this now, it has been long enough.

Comment 3

[Andrew Halberstadt [:ahal]]

Posted an intent to remove to firefox-dev, barring objections I'll land EOD today. Also setting leave-open so we can remove the hooks completely after a couple of weeks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/912ba3bc7211
[lint] Obsolete the eslintvalidate hooks by printing error message with upgrade path, r=standard8

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/912ba3bc7211

Comment 6

[Andrew Halberstadt [:ahal]]

It's been a month since the hooks have been printing an error message. It's probably safe to remove the files from the tree now.

I ended up filing a new bug for the simple reason that mozreview won't let me push a second unrelated patch with the same bug number.