1429232 - SM: Restore the datetimepicker bindings/styles after their removal in bug 1428849

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1428849 removes bindings and styles for the datetimepicker. The only usage is the birthday field in AB.

Comment 1

[Stefan [:stefanh]]

Attachment: WIP

Not tested yet.

Comment 2

[Stefan [:stefanh]]

Attachment: Another WIP

Note to self: I missed Modern's cardDialog.css, but I should use a css file in content instead.

Comment 3

[Stefan [:stefanh]]

Attachment: Part 1: Add suite-specific paths in datetimepicker.xml

Richard, I want the suite css files in another location - you're OK with this? This can go in before the suite-specific parts (provided that IanN is OK with this approach).

Comment 4

[Stefan [:stefanh]]

Attachment: Part 2: Use the c-c bindings

This assumes Part 1.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 8942517 [details] [diff] [review]
Part 1: Add suite-specific paths in datetimepicker.xml

Looks good, thanks.

Comment 6

[Ian Neal]

Comment on attachment 8942518 [details] [diff] [review]
Part 2: Use the c-c bindings

>+++ b/suite/common/communicator.css
>+
>+/******* datepicker *******/
>+datepicker[type="popup"] {
>+  -moz-binding: url("chrome://communicator/content/bindings/datetimepicker.xml#datepicker-popup");
>+}
>+
>+datepicker[type="grid"] {
>+  -moz-binding: url("chrome://communicator/content/bindings/datetimepicker.xml#datepicker-grid");
>+}

Don't we also need to add bindings for:
datepicker {
  -moz-binding: url('chrome://communicator/content/bindings/datetimepicker.xml#datepicker');
}

timepicker {
  -moz-binding: url('chrome://communicator/content/bindings/datetimepicker.xml#timepicker');
}

Also if we have moved the bindings to suite/common, shouldn't datetimepicker.dtd be in a similar area with adjustments made to datetimepicker.xml

r=me with those addressed.

Comment 7

[Stefan [:stefanh]]

The timepicker binding wasn't migrated, but I can add the datepicker one.

Comment 8

[Stefan [:stefanh]]

Attachment: Part 2 (r=IanN): Use the c-c bindings and adjust location of datetimepicker.dtd

Comment 9

[Stefan [:stefanh]]

This touches the c-c top dir and also mail/, so I'm sure Jorg wants to land both these attachments.

Comment 10

[Stefan [:stefanh]]

Actually, I'm going to change one ifdef so the indentation matches what I do in common/src/customizeToolbar.xul in bug 1429862.

Comment 11

[Stefan [:stefanh]]

Attachment: Part 2 (r=IanN): Use the c-c bindings and adjust location of datetimepicker.dtd

Comment 12

[Stefan [:stefanh]]

Jorg, I'm sure you want to land these 2 attachments.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/428b9f503c28
SM: Restore the datetimepicker bindings/styles after their removal in bug 1428849, part 1: Add suite-specific paths in datetimepicker.xml. r=Paenglab
https://hg.mozilla.org/comm-central/rev/2ef0cd0692a2
SM: Restore the datetimepicker bindings/styles after their removal in bug 1428849, part 2: Use the c-c bindings and adjust location of datetimepicker.dtd. r=IanN

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/469744d061c1
correct inconsistent use of quotation marks

Comment 15

[Stefan [:stefanh]]

(In reply to Pulsebot from comment #14)
> Pushed by [e-mail]:
> https://hg.mozilla.org/comm-central/rev/469744d061c1
> correct inconsistent use of quotation marks

(I did a c&p from comment #6 and missed the fact that I then used ' instead of ")