Closed Bug 1429232 Opened 3 years ago Closed 3 years ago

SM: Restore the datetimepicker bindings/styles after their removal in bug 1428849

Categories

(SeaMonkey :: General, enhancement)

enhancement
Not set
normal

Tracking

(seamonkey2.56 fixed)

RESOLVED FIXED
seamonkey2.56
Tracking Status
seamonkey2.56 --- fixed

People

(Reporter: Paenglab, Assigned: stefanh)

References

Details

Attachments

(2 files, 4 obsolete files)

Bug 1428849 removes bindings and styles for the datetimepicker. The only usage is the birthday field in AB.
Blocks: 1428849
Attached patch WIP (obsolete) — Splinter Review
Not tested yet.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attached patch Another WIP (obsolete) — Splinter Review
Note to self: I missed Modern's cardDialog.css, but I should use a css file in content instead.
Attachment #8942470 - Attachment is obsolete: true
Richard, I want the suite css files in another location - you're OK with this? This can go in before the suite-specific parts (provided that IanN is OK with this approach).
Attachment #8942475 - Attachment is obsolete: true
Attachment #8942517 - Flags: review?(richard.marti)
Attached patch Part 2: Use the c-c bindings (obsolete) — Splinter Review
This assumes Part 1.
Attachment #8942518 - Flags: review?(iann_bugzilla)
Comment on attachment 8942517 [details] [diff] [review]
Part 1: Add suite-specific paths in datetimepicker.xml

Looks good, thanks.
Attachment #8942517 - Flags: review?(richard.marti) → review+
Comment on attachment 8942518 [details] [diff] [review]
Part 2: Use the c-c bindings

>+++ b/suite/common/communicator.css
>+
>+/******* datepicker *******/
>+datepicker[type="popup"] {
>+  -moz-binding: url("chrome://communicator/content/bindings/datetimepicker.xml#datepicker-popup");
>+}
>+
>+datepicker[type="grid"] {
>+  -moz-binding: url("chrome://communicator/content/bindings/datetimepicker.xml#datepicker-grid");
>+}

Don't we also need to add bindings for:
datepicker {
  -moz-binding: url('chrome://communicator/content/bindings/datetimepicker.xml#datepicker');
}

timepicker {
  -moz-binding: url('chrome://communicator/content/bindings/datetimepicker.xml#timepicker');
}

Also if we have moved the bindings to suite/common, shouldn't datetimepicker.dtd be in a similar area with adjustments made to datetimepicker.xml

r=me with those addressed.
Attachment #8942518 - Flags: review?(iann_bugzilla) → review+
The timepicker binding wasn't migrated, but I can add the datepicker one.
Attachment #8944296 - Attachment description: For check-in (r=IanN) Part 2: Use the c-c bindings and adjust location of datetimepicker.dtd → Part 2 (r=IanN): Use the c-c bindings and adjust location of datetimepicker.dtd
Attachment #8942518 - Attachment is obsolete: true
This touches the c-c top dir and also mail/, so I'm sure Jorg wants to land both these attachments.
Keywords: checkin-needed
Actually, I'm going to change one ifdef so the indentation matches what I do in common/src/customizeToolbar.xul in bug 1429862.
Keywords: checkin-needed
Jorg, I'm sure you want to land these 2 attachments.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/428b9f503c28
SM: Restore the datetimepicker bindings/styles after their removal in bug 1428849, part 1: Add suite-specific paths in datetimepicker.xml. r=Paenglab
https://hg.mozilla.org/comm-central/rev/2ef0cd0692a2
SM: Restore the datetimepicker bindings/styles after their removal in bug 1428849, part 2: Use the c-c bindings and adjust location of datetimepicker.dtd. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Seamonkey2.56
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/comm-central/rev/469744d061c1
correct inconsistent use of quotation marks
(In reply to Pulsebot from comment #14)
> Pushed by stefanh@inbox.com:
> https://hg.mozilla.org/comm-central/rev/469744d061c1
> correct inconsistent use of quotation marks

(I did a c&p from comment #6 and missed the fact that I then used ' instead of ")
You need to log in before you can comment on or make changes to this bug.