1429249 - New tab links don't navigate when clicked

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Oriol Brufau [:Oriol]]

1. Disable activity stream junk
2. Go to about:newtab
3. Click some link

Result: the link is not navigated. Instead I have to right click it and open it in a new tab.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=310b03d6022225dbbcd7db3cba55f940fccbb3ea&tochange=c2e1ad141fd7e257b4a099812acdfdcf576afa0c

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1429249 - Don't prevent link navigation when clicking on tiles.

Review commit: https://reviewboard.mozilla.org/r/211698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211698/

Comment 2

[Andrei Oprea [:andreio]]

Comment on attachment 8941381 [details]
Bug 1429249 - Don't prevent link navigation when clicking on tiles.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211698/diff/1-2/

Comment 3

[Andrei Oprea [:andreio]]

As a result of the previous PR the link handler would prevent navigation by calling preventDefault on the event.

Comment 4

[Ed Lee :Mardak]

Comment on attachment 8941381 [details]
Bug 1429249 - Don't prevent link navigation when clicking on tiles.

https://reviewboard.mozilla.org/r/211698/#review217502

::: browser/base/content/newtab/sites.js:250
(Diff revision 2)
>    /**
>     * Handles site click events.
>     */
>    onClick: function Site_onClick(aEvent) {
>      let pinned = this.isPinned();
>      let tileIndex = this.cell.index;

This looks to be unused from the previous change

Comment 5

[Andrei Oprea [:andreio]]

Comment on attachment 8941381 [details]
Bug 1429249 - Don't prevent link navigation when clicking on tiles.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211698/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da8ba47df0fc
Don't prevent link navigation when clicking on tiles. r=Mardak

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/da8ba47df0fc