1429254 - Style sheet could not be loaded in the Style Editor when reload page

Status: VERIFIED FIXED

(DevTools :: Style Editor, defect, P1)

Description

[magicp]

Attachment: stylesheet-could-not-be-loaded.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20180109100117

Steps to reproduce:
1. Launch Nightly build (20180109100117)
2. Go to https://bugzilla.mozilla.org
3. Open Style Editor (Shift+F7)
4. Reload the page

Actual results:
"Style sheet could not be loaded when reload page..." notification appear and the following errors are logged in the browser console.

Error writing response to: getText  protocol.js:1118
<unavailable>  protocol.js:964
Protocol error (unknownError): this.str.substring is not a function  StyleSheetEditor.jsm:300
Protocol error (unknownError): this.str.substring is not a function  StyleEditorUI.jsm:247
Error writing response to: getText  protocol.js:1118
<unavailable>  protocol.js:964
Protocol error (unknownError): this.str.substring is not a function  StyleSheetEditor.jsm:300
Protocol error (unknownError): this.str.substring is not a function  StyleEditorUI.jsm:247
Error writing response to: getText  protocol.js:1118
<unavailable>  protocol.js:964
Protocol error (unknownError): this.str.substring is not a function  StyleSheetEditor.jsm:300
Protocol error (unknownError): this.str.substring is not a function  StyleEditorUI.jsm:247
Error writing response to: getText  protocol.js:1118
<unavailable>  protocol.js:964
Protocol error (unknownError): this.str.substring is not a function  StyleSheetEditor.jsm:300
Protocol error (unknownError): this.str.substring is not a function  StyleEditorUI.jsm:247


Expected results:
Works fine without error.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c2e1ad141fd7e257b4a099812acdfdcf576afa0c&tochange=e188cb9fe8f5f3e73e06a13cdebde190b142d432

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1429254 - Expand long strings when fetching from network monitor.

In bug 1306892, we started fetching stylesheets from the network monitor when
possible.  However, this only worked for short strings (< 10000 bytes).  For
long strings, we need to also look up the long string actor that holds the
actual text.

Review commit: https://reviewboard.mozilla.org/r/211758/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211758/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7e1201b3bce188f4b35b134d4092cd4aa187213

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8941484 [details]
Bug 1429254 - Expand long strings when fetching from network monitor.

https://reviewboard.mozilla.org/r/211758/#review217558

Thanks a lot for the fix, and for including a test.
Fixes both the StyleEditor and Inspector issues.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59a75c1808ec
Expand long strings when fetching from network monitor. r=jdescottes

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/59a75c1808ec

Comment 8

[magicp]

This bug fix was verified in the latest Nightly build (20180111100722). Thanks!

Comment 9

[dajoyce.br]

Bug occurs in v85.0. Where's the fix?
Note: Running local server (localhost:3000) but occurs on other sites too.

Steps to reproduce:

1. Open/load site.
2. Open developer tools.
3. Reload page.

"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0"

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@dajoyce, I can't reproduce the reported issue using STRs from comment #0, so this seems to be fixed.
If you still see a problem (perhaps using different steps to reproduce) please file a new bug:
https://bugzilla.mozilla.org/enter_bug.cgi?product=DevTools&component=Style%20Editor

Thank you.
Honza

Comment 11

[Julian Descottes [:jdescottes]]

This bug has been closed for 3 years. Maybe it regressed, but we have automated tests for it.
You are probably experiencing a different issue, and we need more information to investigate.

Can you please file a new bug, with more detailed STRs, especially what happens after "Reload page".
Do you see an error message? What is missing? etc...

Thanks