Closed Bug 1429282 Opened 3 years ago Closed 3 years ago

Increase determinism in OSX builds

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: 1427340
Attachment #8941316 - Flags: review?(core-build-config-reviews) → review?(gps)
Comment on attachment 8941316 [details]
Bug 1429282 - Explicitly link against a bunch of OSX frameworks we end up linking.

https://reviewboard.mozilla.org/r/211620/#review217374

Implicit linking... gotta love it.

It would be rad if we could tell the linker to not add implicit frameworks. But I'm guessing there isn't an option for that. I guess the next best thing would be a test of some sort that established an allow list of frameworks (derived from link options in configure?) and errored if any other dependencies crept in. But that is scope bloat and followup fodder.
Attachment #8941316 - Flags: review?(gps) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/a050e10db05c
Explicitly link against a bunch of OSX frameworks we end up linking. r=gps
Blocks: 1429287
https://hg.mozilla.org/mozilla-central/rev/a050e10db05c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.