1429286 - Extend push and notification telemetry

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, enhancement, P2)

Description

[Martin Thomson [:mt:]]

Discussion on push@ concluded that these should be retained indefinitely:

WEB_NOTIFICATION_CLICKED
WEB_NOTIFICATION_PERMISSIONS
WEB_NOTIFICATION_SHOWN
PUSH_API_NOTIFY

Rationale being that these are critical to understanding usage of these APIs and without them we don't get any information.  There is little active work on these right now, but that work seems likely, if sporadic.  Having to restore this sort of probe would make it difficult to respond to these occasional needs with measured changes.

Comment 1

[[e-mail]]

Reviews for permanent data collection (which this represents) requires a point of contact to ask for further details in case of emergencies.

:mt, is that you?

Comment 2

[Martin Thomson [:mt:]]

That was my intent, yes.  I think that I managed to somehow mess that bit up in the questionnaire, sorry.

Comment 3

[[e-mail]]

Comment on attachment 8941326 [details]
Bug 1429286 - Keep critical push and notification telemetry indefinitely

Approved.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b342be42331b
Keep critical push and notification telemetry indefinitely, r=rweiss

Comment 5

[Raul Gurzau (:RaulG)]

Backed out changeset b342be42331b (bug 1429286) for build bustage

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/903540307a209adb6e44b303d5bc4e2c54fd7dcb

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b342be42331bd06b7f173df6ea6bba1511d9626b

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=160770587&repo=mozilla-inbound&lineNumber=3282

[task 2018-02-07T05:18:13.563Z] 05:18:13     INFO -  make[4]: *** Deleting file 'TelemetryHistogramEnums.h'
[task 2018-02-07T05:18:13.563Z] 05:18:13     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-02-07T05:18:13.563Z] 05:18:13     INFO -  TelemetryHistogramEnums.h
[task 2018-02-07T05:18:13.564Z] 05:18:13     INFO -  /builds/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python -m mozbuild.action.file_generate /builds/worker/workspace/build/src/toolkit/components/telemetry/gen_histogram_enum.py main TelemetryHistogramEnums.h .deps/TelemetryHistogramEnums.h.pp /builds/worker/workspace/build/src/toolkit/components/telemetry/Histograms.json /builds/worker/workspace/build/src/dom/base/UseCounters.conf /builds/worker/workspace/build/src/dom/base/nsDeprecatedOperationList.h
[task 2018-02-07T05:18:13.564Z] 05:18:13     INFO -  Histogram "PUSH_API_NOTIFY" should be removed from the whitelist for "bug_numbers" in histogram-whitelists.json.
[task 2018-02-07T05:18:13.564Z] 05:18:13     INFO -  Some errors occurred
[task 2018-02-07T05:18:13.564Z] 05:18:13     INFO -  Exception KeyError: KeyError(139659991430912,) in <module 'threading' from '/usr/lib/python2.7/threading.pyc'> ignored
[task 2018-02-07T05:18:13.564Z] 05:18:13     INFO -  backend.mk:37: recipe for target 'TelemetryHistogramEnums.h' failed
[task 2018-02-07T05:18:13.564Z] 05:18:13     INFO -  make[4]: *** [TelemetryHistogramEnums.h] Error 1
[task 2018-02-07T05:18:13.565Z] 05:18:13     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-02-07T05:18:13.565Z] 05:18:13     INFO -  make[4]: *** Waiting for unfinished jobs....
[task 2018-02-07T05:18:13.580Z] 05:18:13     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/accessible/xpcom'
[task 2018-02-07T05:18:13.581Z] 05:18:13     INFO -  xpcAccEvents.h
[task 2018-02-07T05:18:13.581Z] 05:18:13     INFO -  /builds/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python -m mozbuild.action.file_generate /builds/worker/workspace/build/src/accessible/xpcom/AccEventGen.py gen_files xpcAccEvents.h .deps/xpcAccEvents.h.pp /builds/worker/workspace/build/src/accessible/xpcom/AccEvents.conf ../../xpcom/idl-parser/xpidl/xpidllex.py ../../xpcom/idl-parser/xpidl/xpidlyacc.py
[task 2018-02-07T05:18:13.581Z] 05:18:13     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/accessible/xpcom'
[task 2018-02-07T05:18:13.581Z] 05:18:13     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/accessible/xpcom'
[task 2018-02-07T05:18:13.581Z] 05:18:13     INFO -  ../../config/nsinstall -R -m 644 'xpcAccEvents.h' '../../dist/include'
[task 2018-02-07T05:18:13.581Z] 05:18:13     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/accessible/xpcom'
[task 2018-02-07T05:18:13.637Z] 05:18:13     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-02-07T05:18:13.638Z] 05:18:13     INFO -  TelemetryScalarEnums.h
[task 2018-02-07T05:18:13.638Z] 05:18:13     INFO -  /builds/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python -m mozbuild.action.file_generate /builds/worker/workspace/build/src/toolkit/components/telemetry/gen_scalar_enum.py main TelemetryScalarEnums.h .deps/TelemetryScalarEnums.h.pp /builds/worker/workspace/build/src/toolkit/components/telemetry/Scalars.yaml
[task 2018-02-07T05:18:13.638Z] 05:18:13     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-02-07T05:18:13.694Z] 05:18:13     INFO -  make[4]: *** Deleting file 'TelemetryHistogramData.inc'

Comment 6

[Phabricator Automation]

Comment on attachment 8941326 [details]
Bug 1429286 - Keep critical push and notification telemetry indefinitely

Rebecca Weiss has been removed from the revision.

https://phabricator.services.mozilla.com/D361

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fae9e55fd40
Keep critical push and notification telemetry indefinitely, r=rweiss

Comment 8

[Martin Thomson [:mt:]]

Should be OK now.  Cross checks caught me out, as did the long delay in me getting back to this.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8fae9e55fd40