1429307 - Incorrect radio button form and state

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect, P3)

Description

[Eric Tsai (no more review request accepted)]

STR

1. Navigate https://m.buy123.com.tw/faq/question.
2. Observe radio button form for the “Emoticons”.
3. Tap a radio button.
4. Observe behavior.

**Expected Behavior:**
Radio button has fair size and can be selected.

**Actual Behavior:**
Radio button is displayed very small, hardly visible and can't be selected.

**Note:**
1. Reproducible on Firefox 55.0.2 Release (Mobile) where the form is rectangle.
2. Not reproducible also on Chrome (Mobile) 61.0.3163.98. 
3. Screenshot attached.

**Watchers:**
@softvision-sergiulogigan
@softvision-oana-arbuzov

sv; country: tw
https://webcompat.com/uploads/2017/10/4ea43eb1-1f77-4163-88f7-122c47ad28b5.jpeg

![radiobtnformstate](https://user-images.githubusercontent.com/12184325/31177318-55f43b88-a91e-11e7-87d2-daf966f12866.gif)

Remove paddings could see the radio button, but according to @lochang's comment, native widget should ignore that.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

I guess we should not add the padding here [1]?

[1] https://searchfox.org/mozilla-central/rev/7fb999d1d39418fd331284fab909df076b967ac6/widget/android/nsNativeThemeAndroid.cpp#182

Comment 2

[Louis Chang [:louis]]

(In reply to Jim Chen [:jchen] [:darchons] from comment #1)
> I guess we should not add the padding here [1]?
> 
> [1]
> https://searchfox.org/mozilla-central/rev/
> 7fb999d1d39418fd331284fab909df076b967ac6/widget/android/nsNativeThemeAndroid.
> cpp#182

Yep, you are right. We should not deflate the padding and border for checkbox and radio here.

I will submit the patch and fix the bug. Besides, I think bug 1428676 has the same problem with this bug here.

Comment 3

[Louis Chang [:louis]]

Attachment: Bug 1429307 - return zero padding for checkbox/radio instead of deflating the padding and border on android.

Review commit: https://reviewboard.mozilla.org/r/213458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213458/

Comment 4

[Louis Chang [:louis]]

Hi mats,

Could you review the patch? Thanks.

I think we should return zero padding for checkbox/radio on android like other platforms instead of deflating the padding.

Comment 5

[Louis Chang [:louis]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af439b12c5cb4cc21ed11317a068287db8dd0bd6

Comment 7

[Mats Palmgren (inactive)]

Comment on attachment 8943148 [details]
Bug 1429307 - return zero padding for checkbox/radio instead of deflating the padding and border on android.

https://reviewboard.mozilla.org/r/213458/#review220376

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4662889e8a1a
return zero padding for checkbox/radio instead of deflating the padding and border on android. r=mats

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4662889e8a1a