Closed
Bug 1429323
Opened 6 years ago
Closed 6 years ago
Remove calls to SimpleTest.expectAssertions() from media mochitests
Categories
(Core :: Audio/Video: Playback, enhancement, P5)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(1 file)
Now they can run without failing the assertions.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jwwang
Priority: -- → P5
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8941356 -
Flags: review?(bechen)
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8941356 [details] Bug 1429323 - remove calls to SimpleTest.expectAssertions() from media mochitests. https://reviewboard.mozilla.org/r/211676/#review217442 Which bug fix these assertions when seeking?
Attachment #8941356 -
Flags: review?(bechen) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8941356 [details] Bug 1429323 - remove calls to SimpleTest.expectAssertions() from media mochitests. https://reviewboard.mozilla.org/r/211676/#review217442 I don't know. Maybe we got them fixed along the way of refactoring.
|
||
Comment 4•6 years ago
|
||
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 2 changes to 2 files remote: remote: remote: ************************** ERROR **************************** remote: Rev ee9ac99affd8 needs "Bug N" or "No bug" in the commit message. remote: JW Wang <jwwang@mozilla.com> remote: Bug 1429323 - remove calls to SimpleTest.expectAssertions() from media mochitests. r=bechen remote: remote: MozReview-Commit-ID: GapLJjIGjmK remote: ************************************************************* remote: remote: remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.c_commitmessage hook failed abort: push failed on remote
| Comment hidden (mozreview-request) |
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d14d36fc5161 remove calls to SimpleTest.expectAssertions() from media mochitests. r=bechen
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d14d36fc5161
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•