Closed Bug 1429396 Opened 3 years ago Closed 2 years ago

Remove toolkit/content/global/XPCNativeWrapper.js

Categories

(Toolkit :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: ntim, Assigned: manishkk)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

Keywords: good-first-bug
Hi. I'd like to be assigned to solve this bug. :)


Do I need to do just remove path of 'XPCNativeWrapper.js' from all these files?
https://dxr.mozilla.org/mozilla-central/search?q=XPCNativeWrapper.js&redirect=false
Flags: needinfo?(ntim.bugs)
(In reply to Manish Kumar from comment #1)
> Hi. I'd like to be assigned to solve this bug. :)
Assigned it to you :)

> 
> Do I need to do just remove path of 'XPCNativeWrapper.js' from all these
> files?
> https://dxr.mozilla.org/mozilla-central/search?q=XPCNativeWrapper.
> js&redirect=false


Yes, and also the 'XPCNativeWrapper.js' file itself : https://dxr.mozilla.org/mozilla-central/source/toolkit/content/XPCNativeWrapper.js
Assignee: nobody → 1991manish.kumar
Flags: needinfo?(ntim.bugs)
Attached patch bug1429396 (obsolete) — Splinter Review
Please review the patch.

Thanks
Attachment #8962929 - Flags: review?(ntim.bugs)
Comment on attachment 8962929 [details] [diff] [review]
bug1429396

Review of attachment 8962929 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!

Looks like you forgot to remove toolkit/content/global/XPCNativeWrapper.js 

You need to do `hg rm toolkit/content/global/XPCNativeWrapper.js`
Attachment #8962929 - Flags: review?(ntim.bugs)
Attached patch Bug1429396Splinter Review
Please review.

Thanks
Attachment #8962929 - Attachment is obsolete: true
Attachment #8963021 - Flags: review?(ntim.bugs)
Comment on attachment 8963021 [details] [diff] [review]
Bug1429396

Review of attachment 8963021 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8963021 - Flags: review?(ntim.bugs) → review+
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/941b196e1e3b
Remove toolkit/content/global/XPCNativeWrapper.js r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/941b196e1e3b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.