14294 - _GetPref() & _GetBoolPref() called many times

Status: VERIFIED INVALID

(Core :: Layout, defect, P1)

Description

[Chris McAfee]

linux, apprunner, debug.
The functions _GetPref() & _GetBoolPref() in nsBaseWidget.cpp
are called many, many times as running the app.  Can we
cache this somehow?  This seems like a waste to me.
Yeah it's debug, but we should look for speedups here too.

Comment 1

[ramiro]

The prefs service is cached.  To cache the pref value, you would have to code
pref callbaks or something.

This is debug only code, and there are much bigger fish to fry.  So i dont plan
on fixing it.

Comment 2

[Chris McAfee]

stealing this little fish.

Comment 3

[don]

Do we need to fix the for M12?

Comment 4

[Chris McAfee]

m14

Comment 5

[don]

Hmmmm, methinks this may be what's making the prefs dialog so slow (something
that Rob Malda complained about in Slashdot M12 announcement).  It would be
really nice to fix this for beta 1.  How hard is it?

Comment 6

[Chris McAfee]

moving perf to summary

Comment 7

[sairuh (rarely reading bugmail)]

spam: added self to cc list as this might affect my realm.

Comment 8

[leger]

Moving "perf" to keyword field.  This is the are we use now :-)

Comment 9

[Chris McAfee]

m15

Comment 10

[Mike Shaver (:shaver emeritus)]

It's a debug build, and it's probably the paint-flashing stuff.  We don't care

about performance of debug builds.

Comment 11

[Chris Petersen]

Marking verfied invalid per last comments.