address book int yarn code is incorrect for ints > 4 bytes long as a string

VERIFIED FIXED

Status

SeaMonkey
MailNews: Address Book & Contacts
VERIFIED FIXED
16 years ago
13 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.03 KB, patch
Cavin Song
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
the address book code that converts ints to yarns is incorrectly setting the
size field for the yarn. Patch upcoming.
(Assignee)

Comment 1

16 years ago
Created attachment 82776 [details] [diff] [review]
proposed fix

the code was setting the size of the yarn to be the size of the pointer (4),
not the size of the buffer (100).
Comment on attachment 82776 [details] [diff] [review]
proposed fix

sr=sspitzer
Attachment #82776 - Flags: superreview+
(Assignee)

Comment 3

16 years ago
Cavin, can you review? thx.

Comment 4

16 years ago
Comment on attachment 82776 [details] [diff] [review]
proposed fix

r=cavin.
Attachment #82776 - Flags: review+
(Assignee)

Comment 5

16 years ago
fix checked in, qa->stephend for lxr verification.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
QA Contact: nbaca → stephend
Resolution: --- → FIXED
I've verified that the patch as listed in this bug landed:

1.98 bienvenu%netscape.com May 8 12:53 fix address book int yarn code to set
yarn size correctly r=cavin, sr=sspitzer 142941
Status: RESOLVED → VERIFIED
OS: Windows 2000 → All
Hardware: PC → All
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.