Closed Bug 142941 Opened 22 years ago Closed 22 years ago

address book int yarn code is incorrect for ints > 4 bytes long as a string

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Product:
SeaMonkey
Component:
MailNews: Address Book & Contacts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

Attachments

(1 file)

proposed fix
1.03 KB, patch
cavin
: review+
sspitzer
: superreview+
Details | Diff | Splinter Review 
the address book code that converts ints to yarns is incorrectly setting the
size field for the yarn. Patch upcoming.
Attached patch proposed fix — — Splinter Review 
the code was setting the size of the yarn to be the size of the pointer (4),
not the size of the buffer (100).
Comment on attachment 82776 [details] [diff] [review]
proposed fix

sr=sspitzer
Attachment #82776 - Flags: superreview+
Cavin, can you review? thx.
Comment on attachment 82776 [details] [diff] [review]
proposed fix

r=cavin.
Attachment #82776 - Flags: review+
fix checked in, qa->stephend for lxr verification.
Status: NEW → RESOLVED
Closed: 22 years ago
QA Contact: nbaca → stephend
Resolution: --- → FIXED
I've verified that the patch as listed in this bug landed:

1.98 bienvenu%netscape.com May 8 12:53 fix address book int yarn code to set
yarn size correctly r=cavin, sr=sspitzer 142941
Status: RESOLVED → VERIFIED
OS: Windows 2000 → All
Hardware: PC → All
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: