1429442 - Buttons in "type control" popup in reader mode should have tooltips or at least text for accessibility.

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, enhancement, P2)

Description

[Mike Kaply [:mkaply]]

Currently when you click on the Aa in reader mode, you get a set of options, but the icons aren't 100% clear as to what they do. They should have tooltips at least.

In addition, by not having any text, they are not accessible.

Comment 1

[Monika Maheshwari [:MonikaMaheshwari]]

Hi, would like to work on this issue. Can you help me and provide some more info.

Comment 2

[:Gijs (he/him)]

(In reply to Monika Maheshwari [:MonikaMaheshwari] from comment #1)

Hi, would like to work on this issue. Can you help me and provide some more info.

Sure. The relevant reader mode code lives in:

https://searchfox.org/mozilla-central/source/toolkit/components/reader/AboutReader.jsm

and

https://searchfox.org/mozilla-central/source/toolkit/components/reader/content/aboutReader.html

and

https://searchfox.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/aboutReader.properties

We'll need to come up with tooltip text for the buttons in the the popup that appears when you click the "Aa" button on the sidebar in reader mode. We should define those as localizable strings in the aboutReader.properties file. You can then set a "title" attribute on the relevant buttons from the JS in the .jsm, using the strings fetched through the gStrings variable in AboutReader.jsm (see other uses in that file for how to do so) .

Let me know if you get stuck or need more help on some of this.

Comment 3

[trushita]

Hi,
Can I work on this issue?

Comment 4

[:Gijs (he/him)]

(In reply to trushita from comment #3)

Hi,
Can I work on this issue?

Monika asked first, so perhaps there's a different issue you can work on, perhaps bug 1154295 ?

Comment 5

[Monika Maheshwari [:MonikaMaheshwari]]

Hi I am going through the issue and will submit the patch after solving it.

Comment 6

[Monika Maheshwari [:MonikaMaheshwari]]

Hey can you tell me the exact title that I need to put on each button. For example on first button I have gave the title Minus.

Comment 7

[Marco Zehe (:MarcoZ)]

The label should say what the button does. If it's represented by a graphical minus sign, it probably decreases something, so give it a title like "Decrease ..." where ... is what is actually being decreased. For example "Decrease font size" or such.

Comment 8

[Monika Maheshwari [:MonikaMaheshwari]]

Thanks. One more doubt for linting what should I do or run.

Comment 9

[Marco Zehe (:MarcoZ)]

In your build directory, run ./mach eslint <path_to_your_modified_file>

Comment 10

[Monika Maheshwari [:MonikaMaheshwari]]

Thanks for help. I have submit my first patch (bug) and now I am submitting the second patch (bug) but when doing arc diff it is giving details on initial patch. Am I doing it correctly?

Comment 11

[:Gijs (he/him)]

(In reply to Monika Maheshwari [:MonikaMaheshwari] from comment #10)

Thanks for help. I have submit my first patch (bug) and now I am submitting the second patch (bug) but when doing arc diff it is giving details on initial patch. Am I doing it correctly?

It's easiest to use moz-phab submit . to submit the commit for this second bug without affecting the earlier commit for the other bug. See https://github.com/mozilla-conduit/review .

Comment 12

[Monika Maheshwari [:MonikaMaheshwari]]

Attachment: Bug 1429442 - Buttons in "type control" popup in reader mode should have tooltips

Added tooltips in type control for accessibility

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a423e8a55266
Buttons in "type control" popup in reader mode should have tooltips r=Gijs,MarcoZ

Comment 14

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a423e8a55266