Closed Bug 1429456 Opened 2 years ago Closed 2 years ago

Use "in" instead of "as" in "Open links in / as tabs instead of new windows" string in preferences

Categories

(Firefox :: Preferences, enhancement, P5, trivial)

57 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

Per feedback in bug 1424970, we want to swap the preposition from "as" to "in".

(In reply to Meridel from bug 1424970 comment #18)
> Per bug 1424970 Comment 17, I agree that
> "Open links in tabs instead of new windows"
> would be more accurate. 
> 
> Apologies for the late edit, and thank you,  [Ton], for the suggestion.
Comment on attachment 8941564 [details]
Bug 1429456 - update tab vs. windows preference label string another time,

https://reviewboard.mozilla.org/r/211832/#review217644
Attachment #8941564 - Flags: review?(ntim.bugs) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3d470c01d770
update tab vs. windows preference label string another time, r=ntim
https://hg.mozilla.org/mozilla-central/rev/3d470c01d770
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
I have reproduced this bug with Nightly 59.0a1 (2018-01-10)on Windows 10, 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID   : 20180112100121
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [bugday-20180110]
You need to log in before you can comment on or make changes to this bug.