Closed Bug 1429469 Opened 2 years ago Closed 2 years ago

Audit failing WR reftests

Categories

(Core :: Graphics: WebRender, defect, P3)

Other Branch
defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted][wr-mvp][triage])

Attachments

(2 files)

Many of these are passing now, but are fuzzy. Because a fails-if annotation will check for zero fuzz, it will treat any fuzzy tests as failing, and therefore the annotation will "pass". However removing the fails-if and replacing it with an appropriate fuzzy-if will also make the test pass, and is more correct.
Here is a try push which simply ignores every "fails-if(webrender)" annotation. This shows us which tests are still actually failing and which ones are no longer failing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1869a4bf1f0d0cb737203fd39ef371dbc80a643

Based on this I identified the ones that are no longer failing (because they are covered by existing fuzzy annotations for the reftest), or that can be marked fuzzy (because they are visibly just fuzzy, but don't have existing fuzziness annotations to cover them). Here is a try push with the changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd0036b6760f0818f2a32c78b6030105c90d4c1f
Comment on attachment 8941553 [details]
Bug 1429469 - Remove a bunch of fails-if(webrender) annotations.

https://reviewboard.mozilla.org/r/211814/#review217624
Attachment #8941553 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8941554 [details]
Bug 1429469 - Replace fails-if(webrender) annotations with fuzzy checks.

https://reviewboard.mozilla.org/r/211816/#review217626
Attachment #8941554 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edf95858b424
Remove a bunch of fails-if(webrender) annotations. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/3d586753feb2
Replace fails-if(webrender) annotations with fuzzy checks. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/edf95858b424
https://hg.mozilla.org/mozilla-central/rev/3d586753feb2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.