1429490 - SessionHistory Exception "Could not convert JavaScript argument arg 0 [nsISerializationHelper.serializeToString]"

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[Oriol Brufau [:Oriol]]

Sometimes I get this error in the browser console:

SessionHistory: [Exception... "Could not convert JavaScript argument arg 0 [nsISerializationHelper.serializeToString]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: resource://gre/modules/sessionstore/Utils.jsm :: serializePrincipal :: line 125"  data: no]

https://searchfox.org/mozilla-central/rev/03877052c151a8f062eea177f684a2743cd7b1d5/toolkit/modules/sessionstore/Utils.jsm#125

I have Firefox 59, Windows 10.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1429490 - Since nsISerializationHelper.serializeToString may throw, catch the error to prevent loss of session data.

Review commit: https://reviewboard.mozilla.org/r/214026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214026/

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8943654 [details]
Bug 1429490 - Since nsISerializationHelper.serializeToString may throw, catch the error to prevent loss of session data.

https://reviewboard.mozilla.org/r/214026/#review219770

Thanks for adding the fix. Would be curious to find out what the actual problem is though. I have never encountered that so far. Now at least we get some debug info in case we see that error happening again.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/923f5a36fa8d
Since nsISerializationHelper.serializeToString may throw, catch the error to prevent loss of session data. r=ckerschb

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/923f5a36fa8d