Closed Bug 1429490 Opened 2 years ago Closed 2 years ago

SessionHistory Exception "Could not convert JavaScript argument arg 0 [nsISerializationHelper.serializeToString]"

Categories

(Firefox :: Session Restore, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: Oriol, Assigned: mikedeboer)

References

Details

Attachments

(1 file)

Sometimes I get this error in the browser console:

SessionHistory: [Exception... "Could not convert JavaScript argument arg 0 [nsISerializationHelper.serializeToString]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: resource://gre/modules/sessionstore/Utils.jsm :: serializePrincipal :: line 125"  data: no]

https://searchfox.org/mozilla-central/rev/03877052c151a8f062eea177f684a2743cd7b1d5/toolkit/modules/sessionstore/Utils.jsm#125

I have Firefox 59, Windows 10.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8943654 [details]
Bug 1429490 - Since nsISerializationHelper.serializeToString may throw, catch the error to prevent loss of session data.

https://reviewboard.mozilla.org/r/214026/#review219770

Thanks for adding the fix. Would be curious to find out what the actual problem is though. I have never encountered that so far. Now at least we get some debug info in case we see that error happening again.
Attachment #8943654 - Flags: review?(ckerschb) → review+
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/923f5a36fa8d
Since nsISerializationHelper.serializeToString may throw, catch the error to prevent loss of session data. r=ckerschb
https://hg.mozilla.org/mozilla-central/rev/923f5a36fa8d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
See Also: → 1452666
You need to log in before you can comment on or make changes to this bug.