Closed Bug 1429535 Opened 3 years ago Closed 3 years ago

Refactor ScriptLoader::ProcessScriptElement method

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

This method is huge.  Here's a patch to split it up to make it a little easier to follow.
Attachment #8941546 - Flags: review?(amarchesini)
Attachment #8941546 - Flags: review?(amarchesini) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef258af45592
Split up ScriptLoader::ProcessScriptElement method r=baku
Backout by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e52c1fdef97
Backed out changeset ef258af45592 for test_bug704320_preload.html timeouts
I thought I move the part where we set the mElement of a preload request until we were definitely going to use it, but mElement being null is used to indicate whether the request is a preload and hence expected to be in the mPreloads array so this breaks.
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7119bb67da6f
Split up ScriptLoader::ProcessScriptElement method r=baku
https://hg.mozilla.org/mozilla-central/rev/7119bb67da6f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.