Refactor ScriptLoader::ProcessScriptElement method

RESOLVED FIXED in Firefox 59

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This method is huge.  Here's a patch to split it up to make it a little easier to follow.
Attachment #8941546 - Flags: review?(amarchesini)
Attachment #8941546 - Flags: review?(amarchesini) → review+

Comment 1

a year ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef258af45592
Split up ScriptLoader::ProcessScriptElement method r=baku

Comment 2

a year ago
Backout by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e52c1fdef97
Backed out changeset ef258af45592 for test_bug704320_preload.html timeouts
(Assignee)

Comment 3

a year ago
I thought I move the part where we set the mElement of a preload request until we were definitely going to use it, but mElement being null is used to indicate whether the request is a preload and hence expected to be in the mPreloads array so this breaks.

Comment 4

a year ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7119bb67da6f
Split up ScriptLoader::ProcessScriptElement method r=baku

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7119bb67da6f
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.