1429590 - Limit extensions to only setting one home page

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P3)

Description

[Andy McKay]

You can actually set firefox to having multiple home pages. This makes bug 1397809 really hard to do. As of the time of writing this bug zero extensions do this.

Let's restrict extensions to only setting one home page in chrome_settings_overrides.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1429590 - Only allow one homepage to be set by extensions

Review commit: https://reviewboard.mozilla.org/r/217058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217058/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8947332 [details]
Bug 1429590 - Only allow one homepage to be set by extensions

https://reviewboard.mozilla.org/r/217058/#review223066

We usually do these sorts of transformations in `Schemas.normalize()` so if you're inclined to change it there (ie, add a new string format for urlWithNoPipes or something) that would be cool, but this is such a specific narrow case that I'm also fine with doing it here...

Comment 3

[Mark Striemer [:mstriemer]]

Comment on attachment 8947332 [details]
Bug 1429590 - Only allow one homepage to be set by extensions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217058/diff/1-2/

Comment 4

[Mark Striemer [:mstriemer]]

I created a format for this so it's handled by Schemas.normalize() now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a8f7940e108
Only allow one homepage to be set by extensions r=aswan

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/1a8f7940e108

Comment 7

[CosminB]

Attachment: Bug1429590.gif

This issue is verified as fixed on Firefox 60.0a1 (20180301223350) under Windows 7 64-bit and Mac OS X 10.13.2.

Please see the attached video.