Limit extensions to only setting one home page

VERIFIED FIXED in Firefox 60

Status

P3
normal
VERIFIED FIXED
a year ago
7 months ago

People

(Reporter: andy+bugzilla, Assigned: mstriemer)

Tracking

unspecified
mozilla60
Dependency tree / graph

Firefox Tracking Flags

(firefox60 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

a year ago
You can actually set firefox to having multiple home pages. This makes bug 1397809 really hard to do. As of the time of writing this bug zero extensions do this.

Let's restrict extensions to only setting one home page in chrome_settings_overrides.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8947332 [details]
Bug 1429590 - Only allow one homepage to be set by extensions

https://reviewboard.mozilla.org/r/217058/#review223066

We usually do these sorts of transformations in `Schemas.normalize()` so if you're inclined to change it there (ie, add a new string format for urlWithNoPipes or something) that would be cool, but this is such a specific narrow case that I'm also fine with doing it here...
Attachment #8947332 - Flags: review?(aswan) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

11 months ago
I created a format for this so it's handled by Schemas.normalize() now.
Keywords: checkin-needed

Comment 5

11 months ago
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a8f7940e108
Only allow one homepage to be set by extensions r=aswan
Keywords: checkin-needed

Comment 6

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1a8f7940e108
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60

Updated

11 months ago
Depends on: 1440301

Comment 7

11 months ago
Created attachment 8955425 [details]
Bug1429590.gif

This issue is verified as fixed on Firefox 60.0a1 (20180301223350) under Windows 7 64-bit and Mac OS X 10.13.2.

Please see the attached video.

Updated

11 months ago
Status: RESOLVED → VERIFIED
status-firefox60: fixed → verified

Updated

7 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.