1429607 - Log settings during GeckoView example app startup

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[Eugen Sawin [:esawin]]

Log settings during startup of the example app to help tracking configuration issues with Autophone.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1429607-1.0-Log-some-relevant-settings-during-ge.patch

Log some settings when starting up the example app.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8941645 [details] [diff] [review]
0001-Bug-1429607-1.0-Log-some-relevant-settings-during-ge.patch

Review of attachment 8941645 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/GeckoViewActivity.java
@@ +128,5 @@
>              GeckoSessionSettings.USE_REMOTE_DEBUGGER,
>              intent.getBooleanExtra(USE_REMOTE_DEBUGGER_EXTRA, false));
> +
> +        Log.i(LOGTAG, "Load with settings (" +
> +              "multiprocess: " + settings.getBoolean(GeckoSessionSettings.USE_MULTIPROCESS) + ", " +

I think you should just implement toString() on GeckoViewSettings and dump the key/value pairs in the bundle. The key names should be sufficient for identifying the settings.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8941645 [details] [diff] [review]
0001-Bug-1429607-1.0-Log-some-relevant-settings-during-ge.patch

Review of attachment 8941645 [details] [diff] [review]:
-----------------------------------------------------------------

Err..meant to r- sorry!

Comment 4

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1429607-1.1-Log-some-relevant-settings-during-ge.patch

I wasn't sure if we want to dump all the settings, but for the example app this can be convenient.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ed6a8d139a3
[1.1] Log some relevant settings during geckoview_example startup. r=snorp

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2ed6a8d139a3