Closed
Bug 1429651
Opened 8 years ago
Closed 8 years ago
NIST no longer requires the continuous PRNG test. It can be removed.
Categories
(NSS :: Libraries, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
3.36
People
(Reporter: rrelyea, Assigned: rrelyea)
Details
Attachments
(1 file)
|
3.74 KB,
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
NIST no longer requires the continous PRNG test (which was always a weird thing to add to software), so we can remove it along with the data structure to hold it. (this should give us a slight probably unmeasurable performance boost, but memory alignment and cache will probably swamp our ability to measure it).
|
Assignee | |
Comment 1•8 years ago
|
||
I still need to request reviewers for this.
Assignee: nobody → rrelyea
Status: NEW → ASSIGNED
Flags: needinfo?(rrelyea)
|
||
Comment 2•8 years ago
|
||
I suggest to do this soon, and target the NSS 3.36 release.
Target Milestone: --- → 3.36
Version: 3.38 → 3.36
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8941682 -
Flags: review?(franziskuskiefer)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8941682 [details] [diff] [review]
Compiled patch to remove the test.
Review of attachment 8941682 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
But do we still need the call to prng_generateNewBytes in line 447 [1]? Please either remove the line or change the comment before landing.
[1] https://searchfox.org/nss/rev/a93087cfe949ea54a51eb11bd768bb31b7a851dc/lib/freebl/drbg.c#447
Attachment #8941682 -
Flags: review?(franziskuskiefer) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(rrelyea)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•