Closed
Bug 1429674
Opened 8 years ago
Closed 8 years ago
allow embedding patches within an autoland request
Categories
(Conduit Graveyard :: Transplant, enhancement)
Conduit Graveyard
Transplant
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glob, Assigned: glob)
Details
Attachments
(2 files)
currently to submit a patch-based landing request to autoland you need to pass in a url to the patch – usually a s3 hosted resource.
to simplify development and testing i want to allow providing the diff (base64 encoded) within the request. this should only be permitted when "testing" is `true` in config.json.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8942063 [details]
autoland: permit inline patches in dev/test (bug 1429674)
https://reviewboard.mozilla.org/r/212276/#review219046
LGTM
Attachment #8942063 -
Flags: review?(smacleod) → review+
|
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8942064 [details]
autoland: add tests for inline patches (bug 1429674)
https://reviewboard.mozilla.org/r/212278/#review219048
Did a quick pass over this and it looked fine.
Attachment #8942064 -
Flags: review?(smacleod) → review+
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/37f3e2df0887
autoland: permit inline patches in dev/test r=smacleod
https://hg.mozilla.org/hgcustom/version-control-tools/rev/37c8e608ea8d
autoland: add tests for inline patches r=smacleod
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: MozReview → Conduit
|
|
||
Updated•2 years ago
|
Product: Conduit → Conduit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•