Link unit tests for talos/talos/xtalos/etlparser.py to ./mach python-test
RESOLVED
FIXED
in Firefox 62
Status
People
(Reporter: igoldan, Assigned: igoldan)
Tracking
Firefox Tracking Flags
(firefox62 fixed)
Details
Attachments
(2 attachments)
No description provided.
|
Assignee | |
Comment 1•2 years ago
|
||
The unit test residing here [1] isn't run automatically, after one executes ./mach python-test testing/talos/talos/unittests. I didn't include a fix for this when I landed bug 1423353. There are some import configurations for xtalos package, which pytest seems to dislike. I will address them here. [1] testing\talos\talos\unittests\test_xtalos\test_etlparser.py
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → igoldan
|
|
Assignee | |
Updated•Last year
|
Priority: -- → P3
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 4•Last year
|
||
I ran all the perf tests here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=60c2900b07e0ef7180cdcd5aca9f3196a41219f6
|
|
Assignee | |
Updated•Last year
|
Flags: needinfo?(rwood)
|
||
Comment 6•Last year
|
||
Just FYI you may need to rebase, I had a merge conflict applying your first patch (testing/talos/talos/unittests/test_test.py) against the latest inbound.
|
|
||
Comment 7•Last year
|
||
| mozreview-review | ||
Comment on attachment 8983741 [details] Bug 1429687 - Fix existing tests https://reviewboard.mozilla.org/r/249574/#review256292 Applied locally and ran the modified unit tests, they passed fine (OSX). R+ with the one issue addressed first please (re: 'preferences'), thanks! ::: testing/talos/talos/unittests/test_config.py:120 (Diff revision 1) > assert test_dict['w7_counters'] == counters > assert set(test_dict['xperf_counters']) == set(counters + ['counter_extra']) > > > class Test_get_browser_config(object): > - required = ('preferences', 'extensions', 'browser_path', 'browser_wait', > + required = ('extensions', 'browser_path', 'browser_wait', Why was 'preferences' removed completely? It is still used inside Talos. Shouldn't it be in the 'optional' list at least?
Attachment #8983741 -
Flags: review?(rwood) → review+
|
|
||
Comment 8•Last year
|
||
| mozreview-review | ||
Comment on attachment 8983742 [details] Bug 1429687 - Fix import issues https://reviewboard.mozilla.org/r/249576/#review256294 LGTM. Appiled locally and verified via ./mach python-test testing/talos/talos/unittests/. Just the one nit. R+. ::: testing/talos/talos/unittests/python.ini:7 (Diff revision 1) > subsuite = talos > > [test_config.py] > [test_ffsetup.py] > [test_test.py] > +[test_xtalos/test_etlparser.py] Nit: should have a blank line at the end of the file
Attachment #8983742 -
Flags: review?(rwood) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 12•Last year
|
||
| mozreview-review-reply | ||
Comment on attachment 8983741 [details] Bug 1429687 - Fix existing tests https://reviewboard.mozilla.org/r/249574/#review256292 > Why was 'preferences' removed completely? It is still used inside Talos. Shouldn't it be in the 'optional' list at least? Indeed, this is now optional. I just added it there.
|
||
Comment 13•Last year
|
||
Pushed by igoldan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6bf8562cf6d Fix existing tests r=rwood https://hg.mozilla.org/integration/autoland/rev/fcbec6eece3f Fix import issues r=rwood
|
||
Comment 14•Last year
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c6bf8562cf6d https://hg.mozilla.org/mozilla-central/rev/fcbec6eece3f
Status: NEW → RESOLVED
Closed: Last year
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•