Closed
Bug 1429705
Opened 6 years ago
Closed 6 years ago
Enable ESLint rule mozilla/use-services for tools/profiler
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
As we've been doing elsewhere, this continues the work to replace .getService() with Services.jsm uses where possible and enable the mozilla/use-services rule, this has small gains in performance (less boundary crossing) and generally more easy to read code. For tools/profiler, this just affects test files.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8941766 [details] Bug 1429705 - Enable ESLint rule mozilla/use-services for tools/profiler. https://reviewboard.mozilla.org/r/212012/#review217772 Thanks!
Attachment #8941766 -
Flags: review?(mstange) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a89326c8f25c Enable ESLint rule mozilla/use-services for tools/profiler. r=mstange
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a89326c8f25c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•