1429729 - Search suggestions keep displacing awesomebar results as I'm about to click on them

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Marco Castelluccio [:marco]]

I can reproduce bug 1410240 again in the latest Nightly.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Marco Castelluccio [:marco] from comment #0)
> I can reproduce bug 1410240 again in the latest Nightly.

Open Preferences / Search and uncheck the "Show search suggestions ahead of..." option.

This will be considered a bug if:
1. you have both the search bar and the address bar visible, but we still set search suggestions first
2. when you select an history/bookmarks entry WITH THE KEYBOARD we replace it just before you press Enter on it (we should freeze the search as soon as you change the keyboard selection)

Could you please let us know if you're hitting one of these cases, or if it's rather a breakage of your habits and the pref covers it?

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Note: a relnote will be added for Firefox 59.

Comment 3

[Marco Castelluccio [:marco]]

(In reply to Marco Bonardo [::mak] from comment #1)
> (In reply to Marco Castelluccio [:marco] from comment #0)
> > I can reproduce bug 1410240 again in the latest Nightly.
> 
> Open Preferences / Search and uncheck the "Show search suggestions ahead
> of..." option.
> 
> This will be considered a bug if:
> 1. you have both the search bar and the address bar visible, but we still
> set search suggestions first
> 2. when you select an history/bookmarks entry WITH THE KEYBOARD we replace
> it just before you press Enter on it (we should freeze the search as soon as
> you change the keyboard selection)
> 
> Could you please let us know if you're hitting one of these cases, or if
> it's rather a breakage of your habits and the pref covers it?

I didn't know the change was done on purpose.
I'm not hitting 1.
I'm not sure about 2, it's hard to test as the search results are sometimes coming in before I press any key, sometimes after. It looks like when the search results appear after I press the key, then I can select the correct history entry, so I guess I'm not hitting 2. I suppose a very short delay could be introduced to allow users to select history entries before the search results appear, but it would be a useless delay if you actually want to search something.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Marco Castelluccio [:marco] from comment #3)
> I suppose a very short delay
> could be introduced to allow users to select history entries before the
> search results appear, but it would be a useless delay if you actually want
> to search something.

Right, the change has some will to prioritize search, thus a delay on search wouldn't cope with that requirement.
The pref on the other side, allows to have history on top.

I'm marking as invalid because it's on purpose and changeable through prefs, if there is some behavior that looks dubious or bogus, feel free to report it so we can look into that.