1429733 - Adapt iPad XCUITests: Close Tab option removed from PageActionMenu

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

Please see bug 1427911

There are some tests using that option not only for that specific test but for navigating to different menus and so they have to be modified/disabled depending on the case for the iPad tests.

For example, some failing tests:
https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/ActivityStreamTest.swift#L92

https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/ActivityStreamTest.swift#L106

Comment 1

[Isabel Rios[:isabel_rios]]

In theory there are 9 tests affected with error: 
Cannot get from PageOptionsMenu to CloseTabFromPageOptions. See /../FxScreenGraph.swift:758

-Activity Stream tests
testTopSitesRemoveAllExceptDefaultClearPrivateData()
testTopSitesRemoveAllExceptPinnedClearPrivateData()

-Private Browser tests
testiPadDirectAccessPrivateMode()

-Reading View tests
testAddToReadingList()
testAddToReadingListPrivateMode()
testRemoveFromReadingView()
testMarkAsReadAndUnreadFromReadingList()
testRemoveFromReadingList()

-Top Tabs tests
testCloseTabFromPageOptionsMenu()

Those are important tests that it will be better to not to disable so we will look for a solution if possible a general one in FxScreenGraph, if that is not possible then each test will be modified accordingly.

Comment 2

[Isabel Rios[:isabel_rios]]

Looks like there is a solution that fixes all the tests. On FxScreenGraph L#758 adding if: "tablet != true" fixes 8 out of the 9 tests.

That remaining test would not make sense for iPad and could be disabled:
-Top Tabs tests
testCloseTabFromPageOptionsMenu()

Anyway, lets see when bug 1427911 lands if there are more changes...

Comment 3

[Isabel Rios[:isabel_rios]]

Attachment: Pull Request

Comment 4

[Isabel Rios[:isabel_rios]]

New tests are also affected:
-BrowisngPDF tests
 	testBookmarkPDF() 	
	testLongPressOnPDFLinkToAddToReadingList()

Comment 5

[No-Jun Park [:njpark]]

Does this PR also fix BrowsingPDF tests?

Comment 6

[No-Jun Park [:njpark]]

Comment on attachment 8942244 [details] [review]
Pull Request

looks okay to me, let us know whether this also covers the PDF tests

Comment 7

[Isabel Rios[:isabel_rios]]

Those two tests on comment #4 yes, they are fixed with this PR. They fail due to the same error than the other tests: Cannot get from PageOptionsMenu to CloseTabFromPageOptions.
For fixing the third BrowsingPDF test:  	testPinPDFtoTopSites() there is a different bug 1430537

Comment 8

[Isabel Rios[:isabel_rios]]

Merged: https://github.com/mozilla-mobile/firefox-ios/commit/878238d182900690aa56f98254b5850a9c5e983d