1429754 - [Ubuntu] Floating-Point textures is required but not supported

Status: VERIFIED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: issue3.png

[Affected versions]:
59.0a1 (BuildId:20180110221942)

[Unaffected versions]:
58.0b15 (BuildId:20180108140638)
57.0.4 (BuildId:20180103231032)
52.5.3 esr (BuildId:20171226003912)

[Affected platforms]:
Ubuntu 16.04 64bit.

[Steps to reproduce]:
1. Launch Firefox with a clean profile.
2. Access the following link: http://madebyevan.com/webgl-water/.

[Expected result]:
The animation starts successfully.

[Actual result]:
The animation doesn’t start playing and the following error is displayed:” Rendering to floating-point textures is required but not supported”

[Regression range]:

This seems to be a regression:

 Last good revision: 86318931910b1842ac8ca5ded448e0d6d0984343
 First bad revision: 2ba0c8df9a6786d5a70065b03ac66ffbe05695cb

 Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=86318931910b1842ac8ca5ded448e0d6d0984343&tochange=2ba0c8df9a6786d5a70065b03ac66ffbe05695cb


[Additional notes]:
For further details regarding this issue please observe the attached screenshot.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Jeff!

Can you please have a look into this ?

Thanks!

Comment 3

[Kelsey Gilbert [:jgilbert]]

So it turns out that COLOR_CLEAR_VALUE is, on some older drivers, clamped to [0,1] in glGet when the current draw-fb is non-floating-point. This would explain why I was seeing clamping that I was not expecting, but things otherwise seemed to work normally.

Let's remove the probe, remove the cached value check, and trust the driver.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1429754 - Trust the driver about floating point support. -

Remove the probe, and remove the cached value check.
Also remove dead code which relies on this sometimes-clamping glGet query.

Review commit: https://reviewboard.mozilla.org/r/212232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212232/

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8942027 [details]
Bug 1429754 - Trust the driver about floating point support. -

https://reviewboard.mozilla.org/r/212232/#review218014

lgtm.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/add48ffcf303
Trust the driver about floating point support. - r=daoshengmu

Comment 8

[Eliza Balazs [:ebalazs_]]

Backed out changeset add48ffcf303 (bug 1429754) for gl failing in dom/canvas/test/webgl-mochitest/ensure-exts/test_EXT_color_buffer_half_float.html

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=add48ffcf30322b8ecf135e03e3bf333b8847c2c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=success&selectedJob=155819503

log failure: https://treeherder.mozilla.org/logviewer.html#?job_id=155819503&repo=mozilla-inbound&lineNumber=8631

backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5150651a530bb2d7b55fe86709d8c7e1de28de1e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=success

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6d0f79d687b
Trust the driver about floating point support. - r=daoshengmu

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e0486fd4eec
Update test failures.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f6d0f79d687b
https://hg.mozilla.org/mozilla-central/rev/9e0486fd4eec

Comment 13

[Emil Ghitta, QA [:emilghitta]]

This issue is no longer reproducible using Firefox 59.0b5 (BuildId:20180128191456) and Firefox 60.0a1 (BuildId:20180129220114) on Ubuntu 16.04 64bit.