1429765 - Extend lifetime of MEDIA_RECORDER_RECORDING_DURATION, MEDIA_RECORDER_TRACK_ENCODER_INIT_TIMEOUT_TYPE, and SCALARS_MEDIARECORDER.RECORDING_COUNT telemetry probes

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, enhancement)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

These probes are useful for determining usage in the wild of the MediaRecorder.  Extending their lifetime allows continued monitoring for changes in usage.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes.

Extend lifetime of MEDIA_RECORDER_RECORDING_DURATION,
MEDIA_RECORDER_TRACK_ENCODER_INIT_TIMEOUT_TYPE, and
SCALARS_MEDIARECORDER.RECORDING_COUNT telemetry probes.

Review commit: https://reviewboard.mozilla.org/r/212066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212066/

Comment 2

[Chris H-C :chutten]

Comment on attachment 8941821 [details]
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes.

https://reviewboard.mozilla.org/r/212066/#review217802

I'm not a Data Peer so I can't provide the data collection review needed for bumping the expiry of these probes. Please ask one of the peers listed on this wiki page: https://wiki.mozilla.org/Firefox/Data_Collection

I can r+ the code change and the commit message. I would prefer the message contain the reason _why_ we're extending the lifetime, but I expect that'll come out in the data collection review, so I won't be picky :)

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8941821 [details]
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes.

https://reviewboard.mozilla.org/r/212066/#review217802

My bad, thanks for the heads up.

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8941821 [details]
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212066/diff/1-2/

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 8941821 [details]
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes.

https://reviewboard.mozilla.org/r/212066/#review217922

Seems reasonable to continue monitoring MediaRecorder usage/timeouts - is there a plan for that data usage? In general renewing the probe is fine, provided there's a reason you still need it.

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8941821 [details]
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes.

https://reviewboard.mozilla.org/r/212066/#review217922

Currently, it helps guide development resources dedicated to the MediaRecorder component. After putting in place the probes we saw less usage of this feature than expected. However, should usage increase, it would be good to track that.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e299e057fd4
Extend lifetime of MediaRecorder telemetry probes. r=chutten,liuche

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6e299e057fd4