Closed Bug 1429765 Opened 2 years ago Closed 2 years ago

Extend lifetime of MEDIA_RECORDER_RECORDING_DURATION, MEDIA_RECORDER_TRACK_ENCODER_INIT_TIMEOUT_TYPE, and SCALARS_MEDIARECORDER.RECORDING_COUNT telemetry probes

Categories

(Core :: Audio/Video: Recording, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: bryce, Assigned: bryce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

These probes are useful for determining usage in the wild of the MediaRecorder.  Extending their lifetime allows continued monitoring for changes in usage.
Comment on attachment 8941821 [details]
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes.

https://reviewboard.mozilla.org/r/212066/#review217802

I'm not a Data Peer so I can't provide the data collection review needed for bumping the expiry of these probes. Please ask one of the peers listed on this wiki page: https://wiki.mozilla.org/Firefox/Data_Collection

I can r+ the code change and the commit message. I would prefer the message contain the reason _why_ we're extending the lifetime, but I expect that'll come out in the data collection review, so I won't be picky :)
Attachment #8941821 - Flags: review?(chutten) → review+
Comment on attachment 8941821 [details]
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes.

https://reviewboard.mozilla.org/r/212066/#review217802

My bad, thanks for the heads up.
Blocks: 1394943
Comment on attachment 8941821 [details]
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes.

https://reviewboard.mozilla.org/r/212066/#review217922

Seems reasonable to continue monitoring MediaRecorder usage/timeouts - is there a plan for that data usage? In general renewing the probe is fine, provided there's a reason you still need it.
Attachment #8941821 - Flags: review?(liuche) → review+
Comment on attachment 8941821 [details]
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes.

https://reviewboard.mozilla.org/r/212066/#review217922

Currently, it helps guide development resources dedicated to the MediaRecorder component. After putting in place the probes we saw less usage of this feature than expected. However, should usage increase, it would be good to track that.
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e299e057fd4
Extend lifetime of MediaRecorder telemetry probes. r=chutten,liuche
https://hg.mozilla.org/mozilla-central/rev/6e299e057fd4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
See Also: → 1480589
Assignee: nobody → bvandyk
You need to log in before you can comment on or make changes to this bug.