1429778 - Update test262 (January 2018 edition)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Comment 1

[André Bargull [:anba]]

Attachment: bug1429778-part1-update-importer.patch

- Marks the new features flags "Array.prototype.flatMap" and "Array.prototype.flatten" as unsupported (bug 1421398).
- Adds a new feature check category for conditionally enabled features, so we don't need to mark every file explicitly when conditionally enabled features are used.
- Updates a comment about the currently unused "phase" tag for negative tests.
- Removes the explicit include for "testBuiltInObject.js", because upstream removed this file.

Comment 2

[André Bargull [:anba]]

Attachment: bug1429778-part2-update-files.patch

Updated test262 files with test262-update.py

Comment 3

[André Bargull [:anba]]

Attachment: bug1429778-part3-update-excl.patch

- Move the conditionally enabled tests for "Intl" and "SIMD" to the block for conditionally enabled tests.
- Disable complete "Atomics" and "SharedArrayBuffer" directories instead of listing each file individually.
- Three tests using "SharedArrayBuffer" are missing the "SharedArrayBuffer" features tag, mark them explicitly as only conditionally supported. (I'll prepare a PR for upstream to add the missing features tag.)
- Update the list of failing tests:
  - Three new tests for typed arrays with detached array buffers.
  - Two Intl tests were renamed upstream.
  - An expected failure for bug 1321616.
  - One test file is incorrect (I'll prepare a PR to fix this upstream).

Comment 4

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=00f9e6ca0469c130f97a42f5a66f230599e2bf14

Comment 5

[André Bargull [:anba]]

Attachment: bug1429778-part4-enable-more-tests.patch

Enable more tests which are now passing and remove test exclusions for removed tests:

- https://github.com/tc39/test262/pull/914 updated test262 to avoid "name" as a global variable name.
- https://github.com/tc39/test262/pull/1041 removed Object.defineProperty tests for the global object.
- And :jonco fixed bug 1340304 in bug 1420420.

Comment 6

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8942017 [details] [diff] [review]
bug1429778-part4-enable-more-tests.patch

Review of attachment 8942017 [details] [diff] [review]:
-----------------------------------------------------------------

Good stuff.

Comment 7

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=25c7deda19c6823f22b86bd509c9dbab8e85917a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03a6d763743d
Part 1: Update test262 unsupported features list. r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/a87567bd0018
Part 2: Update test262 - January 2018 edition. rs=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9440c1e1d17
Part 3: Update test262 exclusion list. r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d64b00f5795
Part 4: Enable more tests which are now passing. r=sfink

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/03a6d763743d
https://hg.mozilla.org/mozilla-central/rev/a87567bd0018
https://hg.mozilla.org/mozilla-central/rev/b9440c1e1d17
https://hg.mozilla.org/mozilla-central/rev/5d64b00f5795