1429809 - import_perf_data management command is currently broken

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P3)

Description

[William Lachance (:wlach)]

Since it's last been touched/used, some of the backend assumptions of the ingest_perf_data command have changed (at the least, it's still using datasource-style job/result_set_id references, which are no longer valid and won't pass foreign key checks).

I'm reluctant to just outright delete this code as I suspect something like it will be needed at some point to debug a problem. But we should at least warn a potential user of it that it isn't likely to work. I think an error message might work here.

If we ever fix things up, we should probably solve bug 1266451 as well so this doesn't happen again.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3126

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8941864 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3126

Sorry about all this :( I wish things were easier here.

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8941864 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3126

(Stealing review)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/156bbd6c1b5288bf1bed6b1fec8d7e343039ece2
Bug 1429809 - Disable import_perf_data because it's broken (#3126)

Comment 5

[Ionuț Goldan [:igoldan]]

This command has been re enabled.