Closed Bug 1429809 Opened 2 years ago Closed 27 days ago

import_perf_data management command is currently broken

Categories

(Tree Management :: Perfherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Unassigned)

References

Details

Attachments

(1 file)

Since it's last been touched/used, some of the backend assumptions of the ingest_perf_data command have changed (at the least, it's still using datasource-style job/result_set_id references, which are no longer valid and won't pass foreign key checks).

I'm reluctant to just outright delete this code as I suspect something like it will be needed at some point to debug a problem. But we should at least warn a potential user of it that it isn't likely to work. I think an error message might work here.

If we ever fix things up, we should probably solve bug 1266451 as well so this doesn't happen again.
Comment on attachment 8941864 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3126

Sorry about all this :( I wish things were easier here.
Attachment #8941864 - Flags: review?(igoldan)
Comment on attachment 8941864 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3126

(Stealing review)
Attachment #8941864 - Flags: review?(igoldan) → review+
Attachment #8941864 - Flags: checkin+
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

This command has been re enabled.

Status: REOPENED → RESOLVED
Closed: 9 months ago27 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.