1429817 - Incorrect height for topsite buttons

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Andrei Oprea [:andreio]]

Attachment: edit_win.png

Observe the small white gap when hovering the topsite actions. This seems to be windows only.

Comment 1

[Andrei Oprea [:andreio]]

Windows seems to have some inconsistencies when it comes to computed dimensions which causes this issue but also noticed another one related: when you click "Edit" the modal with the topsites is slightly shifted from where the topsites are normally.

Comment 2

[Andrei Oprea [:andreio]]

> document.querySelectorAll('.top-sites-list').forEach(e => console.log(e.getClientRects()))

Inspecting the size and position of the top sites containers on Windows shows different values (vs Mac showing same values) for normal vs edit mode but I wasn't able to pin down an exact property that is causing this.

The fact that we have two different sets of topsites makes debugging more complicated.

I know that some of the values for margin/padding etc of various elements need to be updated so I will pause work on this bug.

Comment 3

[Andrei Oprea [:andreio]]

This will be fixed when bug 1432899 lands.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

we removed this in bug 1432899

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/97b3915d56c4

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Firefox: 60.0a1, Build ID 20180131220303

This issue is no longer reproducible because the whole section was removed in Bug 1432899. Verified on Windows 10 x64, Ubuntu 14.04 x64 and Mac 10.12, with the latest Nightly (60.0a1) build installed.