1429825 - Dragging and Dropping a Top Site in the same position with the trackpad wrongly opens the site

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: top site wrongly opened when dropped in initial area.mov

[Affected versions]:
- Firefox 59.0a1 Build ID 20180111100722

[Affected Platforms]:
- Mac 10.11 and 10.12

[Prerequisites]:
- Have a clean new profile.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites and open a new profile.
2. Drag a Top Site to a different position and then drop it in its initial position.
3. Observe the behavior.
 
[Expected results]:
- Nothing happens.

[Actual results]:
- The site is opened.

[Notes]:
- The issue is not reproducible with a mouse.
- It seems like the issue was caused by bug 1428488.
- Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

andreio reproduced this on 10.13.2

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3941

Comment 3

[Ed Lee :Mardak]

Grabbed this after some discussion on irc

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/46d132fe5755a978604c05d832fa30758f020038
fix(topsites): Prevent mysterious trackpad clicks after dragging (#3941)

Fix Bug 1429825 - Dragging and Dropping a Top Site in the same position with the trackpad wrongly opens the site

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8ae1faf4646f

Comment 6

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Nightly build (Build ID 	20180121220252) Mac 10.12 and 10.11.