TFO is disabled on Mac if cross-compiler is used

RESOLVED FIXED in Firefox 59

Status

()

Product:
Core
Component:
Networking: HTTP
Status:
RESOLVED FIXED
Reported:
a year ago
Modified:
a year ago

People

(Reporter: dragana, Assigned: dragana)

Tracking

Version:
59 Branch
Target:
mozilla59
Points:
1

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment)

bug_1429830.patch
1.79 KB, patch
u408661
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
a year ago 
Build configuration relies on Darwin version being set. When a cross-compile is use it is not set. Therefore TFO is disabled on Mac on Nightly.
(Assignee)

Comment 1

•
a year ago 

        Attachment #8941886 -
        Flags: review?(hurley)

    
    

      

        



        		

        



        		

        

          
        

      


      

        
          

            Comment 2
          

          •
          
a year ago
          

        		
      


      

        
        
      

    


    
  
Comment on attachment 8941886 [details] [diff] [review]
bug_1429830.patch

Review of attachment 8941886 [details] [diff] [review]:
-----------------------------------------------------------------

Yaaaaay, cross-compiling is a dumpster fire!

        Attachment #8941886 -
        Flags: review?(hurley) → review+

    
    

      

        



        		

        



        		

        

          
        

      


      

        
          

            Comment 3
          

          •
          
a year ago
          

        		
      


      

        
        
      

    


    
  
Pushed by dd.mozilla@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26e7833d765c
Enable TFO is a cross-compiler is used.r=nwgh

    
    

      

        



        		

        



        		

        

          
        

      


      

        
          

            Comment 4
          

          •
          
a year ago
          

        		
      


      

        bugherder
        
      

    


    
  
https://hg.mozilla.org/mozilla-central/rev/26e7833d765c
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59

          You need to log in
          before you can comment on or make changes to this bug.