Closed Bug 1429830 Opened 3 years ago Closed 3 years ago

TFO is disabled on Mac if cross-compiler is used

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Version:
59 Branch
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: dragana, Assigned: dragana)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

bug_1429830.patch
1.79 KB, patch
u408661
: review+
Details | Diff | Splinter Review 
Build configuration relies on Darwin version being set. When a cross-compile is use it is not set. Therefore TFO is disabled on Mac on Nightly.
Attachment #8941886 - Flags: review?(hurley)
Comment on attachment 8941886 [details] [diff] [review]
bug_1429830.patch

Review of attachment 8941886 [details] [diff] [review]:
-----------------------------------------------------------------

Yaaaaay, cross-compiling is a dumpster fire!
Attachment #8941886 - Flags: review?(hurley) → review+
Pushed by dd.mozilla@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26e7833d765c
Enable TFO is a cross-compiler is used.r=nwgh
https://hg.mozilla.org/mozilla-central/rev/26e7833d765c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.