1429951 - Get non-premultiplied alpha webgl-color-test.html reftests passing

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

Right now on Linux and OS X (and probably windows as well) the webgl-color-test.html reftests that have alpha and no premultiplication are failing. The rendering appears to always have premultiplied alpha.

I have some patches to reinstate the non-premultiplied alpha in webrender (it was removed in servo/webrender#2021) and use it for these canvas textures, which fixes the reftest failures.

Try push with the WIPs is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd14ddf6b5fd41a063d7bb4982bb031f200ddcfe

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Filed https://github.com/servo/webrender/pull/2295 with the WR patch.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Propagate non-premultiplied flag from TextureFlags to WR

And this is the gecko side.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1429951 - Propagate the non-premultiplied flag for textures to WR.

Review commit: https://reviewboard.mozilla.org/r/213654/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213654/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aff207a890e6326fa3caa834b7ec7f90c469700e

Comment 5

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8943327 [details]
Bug 1429951 - Propagate the non-premultiplied flag for textures to WR.

https://reviewboard.mozilla.org/r/213654/#review219490

Looks good!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bb1a5b5510b
Propagate the non-premultiplied flag for textures to WR. r=sotaro

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6bb1a5b5510b