Closed Bug 1429963 Opened 2 years ago Closed 2 years ago

RBAB can't be trusted on Mesa

Categories

(Core :: Canvas: WebGL, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

Relying on RBAB for DrawElementsInstanced hangs the GPU on Mesa.
This is apparent when running conformance/extensions/angle-instanced-arrays-out-of-bounds.html.
Re-enabling index validation cures this.
So actually I made a standalone CPP testcase, and I think we're just seeing the driver struggle to render 0x7fffffff instances, which turns this subtest into a context-loss test, instead of a bounds test.

For better or worse, this just became our go-to test for context-loss handling. :)

(This does presently stand in the way of 1.0.3 conformance on Linux+Mesa)
Priority: P1 → P3
Comment on attachment 8943041 [details]
Bug 1429963 - Don't allow RBAB on Mesa for now. -

https://reviewboard.mozilla.org/r/212236/#review219120

LGTM :)
Attachment #8943041 - Flags: review?(cleu) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b730501efa0
Don't allow RBAB on Mesa for now. - r=lenzak
https://hg.mozilla.org/mozilla-central/rev/5b730501efa0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.