1429974 - TypeError: this.syncFromShowSearchSuggestionsFirstPref is not a function

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[magicp]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20180111220102

Steps to reproduce:
1. Launch Nightly
2. Open about:preferences > Search
3. Check off(or on) "Show search suggestions ahead of browsing history in address bar results"

Actual results:
The following error is logged in the Browser Console.

TypeError: this.syncFromShowSearchSuggestionsFirstPref is not a function: _initShowSearchSuggestionsFirst/<@chrome://browser/content/preferences/in-content/search.js:74:7
emit@resource://gre/modules/EventEmitter.jsm:152:11
set value@chrome://global/content/preferencesBindings.js:478:9
_syncToShowSearchSuggestionsFirstPref@chrome://browser/content/preferences/in-content/search.js:104:5
_initShowSearchSuggestionsFirst/<@chrome://browser/content/preferences/in-content/search.js:79:7
EventListener.handleEvent*_initShowSearchSuggestionsFirst@chrome://browser/content/preferences/in-content/search.js:78:5
init@chrome://browser/content/preferences/in-content/search.js:65:5
init@chrome://browser/content/preferences/in-content/preferences.js:52:7
initializeCategories@chrome://browser/content/preferences/in-content/findInPage.js:70:11
init/<@chrome://browser/content/preferences/in-content/findInPage.js:27:40
requestIdleCallback handler*init@chrome://browser/content/preferences/in-content/findInPage.js:27:7
init_all@chrome://browser/content/preferences/in-content/preferences.js:70:3
EventListener.handleEvent*@chrome://browser/content/preferences/in-content/preferences.js:58:1
  EventEmitter.jsm:156


Expected results:
No error.

Comment 1

[Drew Willcoxon :adw]

Thanks for filing this.

Fortunately the error itself doesn't cause any problems, and it only means that when the pref is changed outside of the preferences UI *and* the preferences UI is open, the checkbox won't be updated properly.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1429974 - TypeError: this.syncFromShowSearchSuggestionsFirstPref is not a function.

Review commit: https://reviewboard.mozilla.org/r/213252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213252/

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 8942984 [details]
Bug 1429974 - TypeError: this.syncFromShowSearchSuggestionsFirstPref is not a function.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213252/diff/1-2/

Comment 4

[Drew Willcoxon :adw]

I updated the test to check this path.  That would have caught the problem.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8942984 [details]
Bug 1429974 - TypeError: this.syncFromShowSearchSuggestionsFirstPref is not a function.

https://reviewboard.mozilla.org/r/213252/#review219236

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d423fdc33dd
TypeError: this.syncFromShowSearchSuggestionsFirstPref is not a function. r=mak

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4d423fdc33dd

Comment 8

[Saheda Reza [:Antora]]

I have reproduced this bug on nightly according to (2018-01-11)

Fixing bug is verified on Latest Beta--
Build ID 	20180215111455
User Agent 	Mozilla/5.0 (Windows NT 6.1; rv:59.0) Gecko/20100101 Firefox/59.0

Tested OS -- Windows7 32bit

Comment 9

[Ciprian Georgiu, Desktop QA]

I have also reproduced this bug using an affected Nightly build (2018-01-11), with STR from comment 0.

Verified fixed on latest Beta 59.0b11 across platforms: Win 7 x64, macOS 10.13 and Ubuntu 16.04 x64.