Closed Bug 1429988 Opened 6 years ago Closed 6 years ago

Minor updates for local pulse ingestion

Categories

(Tree Management :: Treeherder, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I had some minor issues setting up for local pulse ingestion, so am making a couple of proposals (RTD, settings.py) which help the user set it up successfully and have it work right out of the box, without needing IRC help.

o specify RTD that PULSE_DATA_INGESTION_SOURCES is a 'Working example'
o set settings.py PULSE_DATA_INGESTION_SOURCES from "name:" to "exchange:" so it doesn't fail
o maybe set projects: as mozilla-inbound.# with the hash (?)

o update the RTD PULSE_DATA_INGESTION_CONFIG so it doesn't fail eg.

PULSE_DATA_INGESTION_CONFIG = env.url("PULSE_DATA_INGESTION_CONFIG","amqp://mypulseuserid:mypassword@pulse.mozilla.org:5671/?ssl=1")
Comment on attachment 8942052 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3127

For review at your leisure :)
Attachment #8942052 - Flags: review?(cdawson)
Blocks: 1416266
Component: Treeherder: Data Ingestion → Treeherder: Docs & Development
Comment on attachment 8942052 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3127

I had some ideas to handle this a slightly different way.  :)  Thanks!
Attachment #8942052 - Flags: review?(cdawson) → review-
Comment on attachment 8942052 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3127

For re-review. I think I still have at least one tweak but it should be close. I also need to rebase and re-push before any merge.
Attachment #8942052 - Flags: review- → review?(cdawson)
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Comment on attachment 8942052 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3127

Just one tweak requested.  And then we'll see where the tests go once you've rebased.  Thanks for doing this!  :)
Attachment #8942052 - Flags: review?(cdawson) → review-
Comment on attachment 8942052 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3127

Ok, tweak is done and I've rebased/squashed also.
Attachment #8942052 - Flags: review- → review?(cdawson)
Comment on attachment 8942052 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3127

Great work!  Thanks!
Attachment #8942052 - Flags: review?(cdawson) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Treeherder: Docs & Development → TreeHerder
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: