1429989 - dom.select_popup_in_content.enabled should be cached in a bool variable rather than query every time when used

Status: RESOLVED DUPLICATE of bug 1428297

(Core :: Layout: Form Controls, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

The usual way to add a layout pref is to add a new static method in nsLayoutUtils and use Preferences::AddBoolVarCache to cache it.

But currently, the pref dom.select_popup_in_content.enabled is checked with Preferences::GetBool every time when it is used, which feels wasteful, since the latter would cause hashtable lookup on pref table. It should generally be avoided in performance sensitive code.

(The popup constructing code may not be that hot, but it is still good to follow the usual practice rather than using something could be slower.)

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Looks like the patch in bug 1428297 is already doing this.