Closed
Bug 1429994
Opened 6 years ago
Closed 6 years ago
Old video frames seemed to be rendered on Windows
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 1 obsolete file)
12.81 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
During youtube video playback on Windows like the following, some video order seemed to be reverted. We might to recycle video frames too early. https://www.youtube.com/watch?v=gu6JunBsyUQ
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
Updated•6 years ago
|
Blocks: stage-wr-nightly
Priority: -- → P1
Assignee | ||
Comment 1•6 years ago
|
||
Add RenderCompositorANGLE to split ANGLE specific handling and added ID3D11Query handling by referring MLGDeviceD3D11. By it, we expect that when WebRenderTextureHost is recycled, its usage on GPU is already ended.
Assignee | ||
Comment 2•6 years ago
|
||
We could get ID3D11Device from gfx::DeviceManagerDx::Get()->GetCompositorDevice() since Bug 1395107 is addressed.
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1b8aff6056225eb390eda7cee7e1a12ca5a99f4 https://treeherder.mozilla.org/#/jobs?repo=try&revision=5535c64538137d8ac2e30cfb550dd665d6682103
Assignee | ||
Updated•6 years ago
|
Attachment #8943182 -
Flags: review?(nical.bugzilla)
Updated•6 years ago
|
Attachment #8943182 -
Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/70c2890fb875 Use ID3D11Query to wait previous frame completion r=nical
Comment 5•6 years ago
|
||
Backed out for static-analysis bustages on Windows Push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=70c2890fb8759067869e582c71d8123c9535841e Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=157297610&repo=mozilla-inbound&lineNumber=21044 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/29d6104e3166227e759797ef127b5ed60eedbe7d
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 6•6 years ago
|
||
Sorry, explicit keyword was missed and Comment 3 did not catch it :(
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 7•6 years ago
|
||
Fixed the static analysis problem.
Attachment #8943182 -
Attachment is obsolete: true
Attachment #8943807 -
Flags: review+
Assignee | ||
Comment 8•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=15d18ab33f41827766d616bee46d9a7dab00506d
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/29e471159178 Use ID3D11Query to wait previous frame completion r=nical
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/29e471159178
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•