Closed Bug 1429994 Opened 6 years ago Closed 6 years ago

Old video frames seemed to be rendered on Windows

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Unspecified
Windows
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

During youtube video playback on Windows like the following, some video order seemed to be reverted. We might to recycle video frames too early.

  https://www.youtube.com/watch?v=gu6JunBsyUQ
Assignee: nobody → sotaro.ikeda.g
Add RenderCompositorANGLE to split ANGLE specific handling and added ID3D11Query handling by referring MLGDeviceD3D11.

By it, we expect that when WebRenderTextureHost is recycled, its usage on GPU is already ended.
We could get ID3D11Device from  gfx::DeviceManagerDx::Get()->GetCompositorDevice() since Bug 1395107 is addressed.
Attachment #8943182 - Flags: review?(nical.bugzilla)
Attachment #8943182 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70c2890fb875
Use ID3D11Query to wait previous frame completion r=nical
Sorry, explicit keyword was missed and Comment 3 did not catch it :(
Flags: needinfo?(sotaro.ikeda.g)
Fixed the static analysis problem.
Attachment #8943182 - Attachment is obsolete: true
Attachment #8943807 - Flags: review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29e471159178
Use ID3D11Query to wait previous frame completion r=nical
https://hg.mozilla.org/mozilla-central/rev/29e471159178
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.