Closed Bug 1429997 Opened 2 years ago Closed 2 years ago

Add RenderCompositor to wrap platform dependent code

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

Split platform dependent OpenGL related code from RendererOGL to RenderCompositor.

It could simplify bug 1419293.
Blocks: 1419293
Attached patch wip (obsolete) — Splinter Review
Assignee: nobody → sotaro.ikeda.g
Attachment #8942581 - Flags: review?(nical.bugzilla)
Comment on attachment 8942581 [details] [diff] [review]
patch - Add RenderCompositor to wrap platform dependent code

Review of attachment 8942581 [details] [diff] [review]:
-----------------------------------------------------------------

I am super confused by the "Compositor" terminology here (this abstraction doesn't perform any compositing as far as I can tell and doesn't implement the actual Compositor interface), but I don't know what to call it and I can see how it simplifies bug 1419293.
Attachment #8942581 - Flags: review?(nical.bugzilla) → review+
I could not find another better name. I think it is OK to use the name for now.
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9cc2133f215
Add RenderCompositor to wrap platform dependent code r=nical
https://hg.mozilla.org/mozilla-central/rev/c9cc2133f215
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Depends on: 1430694
You need to log in before you can comment on or make changes to this bug.