Add RenderCompositor to wrap platform dependent code

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

a year ago
Split platform dependent OpenGL related code from RendererOGL to RenderCompositor.

It could simplify bug 1419293.
Assignee

Updated

a year ago
Blocks: 1419293
Assignee

Comment 1

a year ago
Posted patch wip (obsolete) — Splinter Review
Assignee: nobody → sotaro.ikeda.g
Assignee

Updated

a year ago
Attachment #8942581 - Flags: review?(nical.bugzilla)
Comment on attachment 8942581 [details] [diff] [review]
patch - Add RenderCompositor to wrap platform dependent code

Review of attachment 8942581 [details] [diff] [review]:
-----------------------------------------------------------------

I am super confused by the "Compositor" terminology here (this abstraction doesn't perform any compositing as far as I can tell and doesn't implement the actual Compositor interface), but I don't know what to call it and I can see how it simplifies bug 1419293.
Attachment #8942581 - Flags: review?(nical.bugzilla) → review+
Assignee

Comment 4

a year ago
I could not find another better name. I think it is OK to use the name for now.

Comment 6

a year ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9cc2133f215
Add RenderCompositor to wrap platform dependent code r=nical

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c9cc2133f215
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee

Updated

a year ago
Depends on: 1430694
You need to log in before you can comment on or make changes to this bug.