1429997 - Add RenderCompositor to wrap platform dependent code

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Sotaro Ikeda [:sotaro]]

Split platform dependent OpenGL related code from RendererOGL to RenderCompositor.

It could simplify bug 1419293.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: wip

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add RenderCompositor to wrap platform dependent code

Comment 3

[Nicolas Silva [:nical]]

Comment on attachment 8942581 [details] [diff] [review]
patch - Add RenderCompositor to wrap platform dependent code

Review of attachment 8942581 [details] [diff] [review]:
-----------------------------------------------------------------

I am super confused by the "Compositor" terminology here (this abstraction doesn't perform any compositing as far as I can tell and doesn't implement the actual Compositor interface), but I don't know what to call it and I can see how it simplifies bug 1419293.

Comment 4

[Sotaro Ikeda [:sotaro]]

I could not find another better name. I think it is OK to use the name for now.

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8c06f34ac33a22c30f3e9fbeb111d252a654a6a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9cc2133f215
Add RenderCompositor to wrap platform dependent code r=nical

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c9cc2133f215