1430005 - Simplify some task configurations items related to the default docker image

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1430005 - For mozharness jobs, rely on the default being set by the mozharness transform.

The mozharness transform is supposed to set the docker image to
desktop-build when not already set, but was not doing it properly.

I guess this is why some jobs were setting the image themselves, despite
using the mozharness transform.

Consequently, don't manually set the image to desktop-build when it's
the default.

Review commit: https://reviewboard.mozilla.org/r/212362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212362/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1430005 - Refactor spidermonkey tc configurations.

With the use of job-defaults, we can avoid a lot of repetition from
those definitions.

Review commit: https://reviewboard.mozilla.org/r/212364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212364/

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8942109 [details]
Bug 1430005 - For mozharness jobs, rely on the default being set by the mozharness transform.

https://reviewboard.mozilla.org/r/212362/#review218422

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8942110 [details]
Bug 1430005 - Refactor spidermonkey tc configurations.

https://reviewboard.mozilla.org/r/212364/#review218424

r+ assuming you generated before and after outputs and there were no important differences..

Comment 5

[Mike Hommey [:glandium]]

(In reply to Dustin J. Mitchell [:dustin] from comment #4)
> Comment on attachment 8942110 [details]
> Bug 1430005 - Refactor spidermonkey tc configurations.
> 
> https://reviewboard.mozilla.org/r/212364/#review218424
> 
> r+ assuming you generated before and after outputs and there were no
> important differences..

As a matter of fact, I did. The only differences in full-task-graph.json are:
- two jobs now having a TOOLTOOL_MANIFEST that didn't have one
- one job having a larger maxRunTime
- an upload_to_task_id difference in repo-update-hsts-hpkp-blocklist

The first two are pretty "meh", and the last seems to always happen.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d0a31ff12e5
For mozharness jobs, rely on the default being set by the mozharness transform. r=dustin
https://hg.mozilla.org/integration/autoland/rev/5111f1ad412a
Refactor spidermonkey tc configurations. r=dustin

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/8d0a31ff12e5
https://hg.mozilla.org/mozilla-central/rev/5111f1ad412a