1430023 - Get rid of the remaining code bits about localstore.rdf and rdf in general

Status: RESOLVED FIXED

Description

[Marco Bonardo [::mak] (Away 7-25 Aug)]

localstore.rdf is gone from some time (Firefox 34), so it sounds like we could get rid of:

1. the migration code from xulstore and the code supporting it.
2. if we didn't yet also remove the file from the profile with a migration
3. There's also an animals.rdf file that I'm not sure what's about (probably testing) and can be removed.
4.  I also think (to be verified) the rdf/datasource folder may not be needed anymore?
5. NS_APP_LOCALSTORE_50_FILE, NS_LOCALSTORE_UNSAFE_FILE
6. https://searchfox.org/mozilla-central/search?q=localstore.rdf&path=

Comment 1

[Axel Hecht]

bug 1425356 stopped using animals.rdf, but didn't remove the file.

Not sure about the other stuff.

Disclaimer, I'm not sure if this bug is well-served by being in the RDF component, as nobody works here. All lights are out. That said, if you know someone that intends to work on this, I don't mind this bug being here.

I'd also appreciate help with the triage. RDF bugs are generally P5 or WONTFIX, unless there's an out-of-RDF-land priority.

Comment 2

[Marco Bonardo [::mak] (Away 7-25 Aug)]

(In reply to Axel Hecht from comment #1)
> bug 1425356 stopped using animals.rdf, but didn't remove the file.

good to know!

> Disclaimer, I'm not sure if this bug is well-served by being in the RDF
> component, as nobody works here. 

It blocks the kill rdf bug, that is all we need, people interested in that project will look at its dependencies, there's interest in removals of old tech like XBL/XUL/RDF in general, so I'm not worried.

(In reply to Axel Hecht from comment #1)
> I'd also appreciate help with the triage. RDF bugs are generally P5 or
> WONTFIX, unless there's an out-of-RDF-land priority.

I agree, removal bugs should likely be P3 (backlog), anything affecting TB or comm-central could be P5. Anything else wontfix.

Comment 3

[Marco Bonardo [::mak] (Away 7-25 Aug)]

Hi Kris, why was this resolved when some of the code points in comment 0 still exist?

Comment 4

[Kris Maglione [:kmag]]

I deleted every reference to RDF I could find in bug 833098 and nothing seemed to break. Please reopen if I missed something, but perhaps remove it as a blocker.

Comment 5

[Marco Bonardo [::mak] (Away 7-25 Aug)]

Ah yeah, not a blocker, it's mostly about unused leftovers referring to localstore.rdf (though I don't know if comm-central may use any of those). Anyway, I'm reopening and inverting the dependencies.

Comment 6

[Marco Bonardo [::mak] (Away 7-25 Aug)]

Attachment: Stop using LStoreS in comm-central

Comment 7

[Marco Bonardo [::mak] (Away 7-25 Aug)]

Attachment: Bug 1430023 - Get rid of some remaining localstore.rdf code.

Review commit: https://reviewboard.mozilla.org/r/242650/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242650/

Comment 8

[Marco Bonardo [::mak] (Away 7-25 Aug)]

Comment on attachment 8974322 [details]
Bug 1430023 - Get rid of some remaining localstore.rdf code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242650/diff/1-2/

Comment 9

[Jorg K (GMT+2)]

Comment on attachment 8974321 [details] [diff] [review]
Stop using LStoreS in comm-central

Thanks, this looks good.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c0b88c3cd2cd
Stop using LStoreS in comm-central. r=jorgk

Comment 11

[Dave Townsend [:mossop] (he/him)]

Comment on attachment 8974322 [details]
Bug 1430023 - Get rid of some remaining localstore.rdf code.

https://reviewboard.mozilla.org/r/242650/#review250084

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba79a9e472c0
Get rid of some remaining localstore.rdf code. r=mossop

Comment 13

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ba79a9e472c0