Go to about:preferences, open Page Info -> Security. Nothing in there has really any use and some parts are also wrong (especially "Have I visited this site before"). We should just disable it on about: pages.
(In reply to Johann Hofmann [:johannh] from comment #0) > We should just disable it on about: pages. Other Page Info tabs that are irrelevant are typically hidden rather than disabled.
I'd like to work on this. Could you point me in the right direction?
Of course! The code for the security view lives in https://searchfox.org/mozilla-central/source/browser/base/content/pageinfo/security.js The relevant part of code is located in the securityOnLoad function: https://searchfox.org/mozilla-central/rev/e9a067a401e41017766f4ab90bc3906603273d51/browser/base/content/pageinfo/security.js#169 Here we do a call to _getSecurityInfo and hide the tab if no security info is available. You could add a check in _getSecurityInfo that compares the scheme of the uri with "about" and returns null if they are the same. Does that make sense to you? :) Thanks!
Assignee: nobody → arjunkrishnababu96
Status: NEW → ASSIGNED
Hey Arjun, are you still working on this? Do you need any more help? Thanks! :)
I'm extremely sorry for the delay! The past couple of weeks have been very busy for me (I'm a grad student in US). I am still interested in working on this. I should be able to find time to work on this before next Monday. Does that work?
Flags: needinfo?(arjunkrishnababu96) → needinfo?(jhofmann)
Sure, no worries, just wanted to check in on this :)
This is the change I have done so far. At the moment I'm hiding the security tab rather disabling it (as per comment 1). Should I disable the security view? I've done manual testing, and it seems to work. The diff output has been attached; let me know if it looks good or I need to make further changes.
Comment on attachment 8949255 [details] [diff] [review] bug1430060_diff.patch Sorry for the delay. This is the correct code to change, but you will need to use uri.scheme, and please use dot-notation (uri.scheme) and double-quotes ("about:"). Thanks!
Attachment #8949255 - Flags: feedback+
Comment on attachment 8950619 [details] Bug 1430060 - Hide Security tab in Page Info when you are on about: pages https://reviewboard.mozilla.org/r/219888/#review226016 Thanks! Let's give this a quick try run and set the checkin-needed flag...
Attachment #8950619 - Flags: review?(jhofmann) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/077920036d7c Hide Security tab in Page Info when you are on about: pages r=johannh
You need to log in before you can comment on or make changes to this bug.